[fr]: Removing old CSS includes from tutorials and fix html href #45328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
|
k8s-ci-robot
added
cncf-cla: no
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/easycla |
seifrajhi
changed the title
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: remyleone The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: e07ae46dadf7a620efed202b1660ab7db4ae0448
|
k8s-ci-robot
added
the
approved
seifrajhi
changed the title
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
French tutorials still include old CSS files. However, if you visit these pages, the browser will try to access them and return 404 (e.g.).
They were removed from the English tutorials in #34188. This PR removes them from the French localisation.
PS: Not directly related to this PR, even though
https://katacoda.com/embed.jswas included on those pages next to the CSS files I did not remove them.I also wanted to let you know that all
Katacoda-relatedpieces should be removed from the localisation since these interactive tutorials are not supported anymore and need replacing. Here is an umbrella issue for this task #41496To get rid of Katacoda, many texts need corrections, which I can't do without French team knowledge.
fixes #45327
/sig docs
/language fr
/area localization