-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Ukrainian localization #45371
Conversation
…ions, stateless applications, and security. Update titles and weights for existing tutorial pages.
Yes. All this is my own work. You may find some of my announcements on LinkedIn regarding this (See https://www.linkedin.com/posts/andrii-holovin-b58201122_робота-над-перекладом-документації-kubernetes-activity-7166731616696967168-jL0Y/?utm_source=share&utm_medium=member_desktop). |
/retitle Improve Ukrainian localization |
I worry that these changes might be too large to review; however, I'll let reviewers for this localization decide. |
@Andygol, I could split this out into four or five smaller PRs squashed down from the commits on this branch. If you're happy for me to do that, I'll open the PRs. (because this is open source, anyone else is also welcome to do that) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
This PR includes untranslated English content.
Thank you, you are right, don't need to big of PR |
👍 It's fine. In case we were doing similar work on some localization platform, the workflow would be much easier 😉 |
How the hell it should be reviewed in GH... |
I propose blindly approving that and hope it does not contain some non-optimal stuff inside |
|
||
<p><a href="https://www.appdirect.com/">AppDirect</a> provides an end-to-end commerce platform for cloud-based products and services. When Director of Software Development Pierre-Alexandre Lacerte began working there in 2014, the company had a monolith application deployed on a "tomcat infrastructure, and the whole release process was complex for what it should be," he says. "There were a lot of manual steps involved, with one engineer building a feature, then another team picking up the change. So you had bottlenecks in the pipeline to ship a feature to production." At the same time, the engineering team was growing, and the company realized it needed a better infrastructure to both support that growth and increase velocity.</p> | ||
|
||
<h2>Solution</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. basically, there not translated 90% at least in a few files
@MaxymVlasov Please do not do this. As already suggested in prior comments, this PR is too large to review and needs to be broken down into smaller PRs so that reviewers can have an easier job to do. "Blind approving", and suggesting to do so, undermines the trust that the Kubernetes project, and our SIG, have put into you as a reviewer and approver of this language. |
@natalisucks, what is your thought about give it a fly as a pilot project, using one of the centralized translation management platforms to streamline the process? |
@Andygol per greater discussion with the UK team in #45175, the next step regarding possible adoption of a translation platform, as I understood, was formulating a team to try and build a proof-of-concept for using this kind of platform, in the hope that several localization teams could weigh in and comment/help |
@natalisucks I hope that in these efforts, SIG Docs will not stand aside and only observe, but will also take an active part in this project as its owner. 👭👬👫🧑🤝🧑🤝 🧑💼 #45209 |
Hi. We're low on capacity for new initiatives, but that's not the same as zero capacity. I hope we can find folk to staff the efforts around experimenting with localization automation. BTW: this PR probably should not merge. See #45371 (comment) |
My recommendation is to close this PR, unless the draft is still being used as a reference to break this down into smaller pieces of work |
Exactly that. There's such a big gap between main and the fork these are from that it will need a lot of work to bring in the changes, and this serves to remind me that it needs doing. |
Acknowledged, thanks @sftim! |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ukrainian team are short on capacity to work on the Ukrainian part of https://k8s.io/ /close |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rolling up some changes made by @Andygol