Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release schedule after August patch releases #47510

Merged

Conversation

jeremyrickard
Copy link
Contributor

This PR updates the schedule to reflect the August patch release.

This was generated with:

schedule-builder -uc data/releases/schedule.yaml

Signed-off-by: Jeremy Rickard <jeremyrrickard@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2024
Copy link

netlify bot commented Aug 15, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 912818a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66be1eb9d2c12800080e9d2d
😎 Deploy Preview https://deploy-preview-47510--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@xmudrii
Copy link
Member

xmudrii commented Aug 15, 2024

/lgtm
/approve
/hold
we might want to use this opportunity to test #45762, if we don't get to merge it soon, unhold this PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55222f1275a379ac72948d1861f5db43655d5ec2

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2024
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sftim
Copy link
Contributor

sftim commented Aug 19, 2024

#45762 has merged; is this still needed?

@xmudrii
Copy link
Member

xmudrii commented Aug 19, 2024

@sftim The workflow still didn't run, we're keeping this PR open as an alternative if we can't get the workflow working (soon). That said, is it possible to manually retrigger the workflow with the latest changes?

@sftim
Copy link
Contributor

sftim commented Aug 19, 2024

That said, is it possible to manually retrigger the workflow with the latest changes?

Maybe. It wouldn't be me doing that though as I have stepped back from being a SIG Docs tech lead.

@jeremyrickard
Copy link
Contributor Author

@katcosgrove @salaxander could ya'll take a look at the Github action that merged with #45762 and see if you can re-trigger it? This should ideally automatically update the patch release schedule.

If we can't get that to run, then we need to merge this PR.

Thanks!

@sftim
Copy link
Contributor

sftim commented Aug 19, 2024

Cc @tengqm (also a tech lead)

@katcosgrove
Copy link
Contributor

@jeremyrickard I have manually triggered the job, and it fails on re-run.

From the logs, attempting to push to k/website returns 403.

@sftim
Copy link
Contributor

sftim commented Aug 19, 2024

@katcosgrove you could try manually triggering it afresh; the behavior changed in 4365f3e which is more recent than the most recent scheduled run.

To trigger the workflow for main, click Run workflow from https://github.com/kubernetes/website/actions/workflows/update-schedule.yml

@katcosgrove
Copy link
Contributor

That surfaces a different error:

https://github.com/kubernetes/website/actions/runs/10457332314

GH Actions is not permitted to create or approve pull requests.

@xmudrii
Copy link
Member

xmudrii commented Aug 19, 2024

Apparently this must be configured on the repo level: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#preventing-github-actions-from-creating-or-approving-pull-requests

By default, when you create a new repository in your personal account, workflows are not allowed to create or approve pull requests. If you create a new repository in an organization, the setting is inherited from what is configured in the organization settings.

Do we have to reach out to GH Admins for this?

@katcosgrove
Copy link
Contributor

I believe so. Tech leads definitely don't have the necessary access.

@xmudrii
Copy link
Member

xmudrii commented Aug 22, 2024

We can't get the action working, so let's proceed with this PR
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit fb9ad35 into kubernetes:main Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants