Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ru] Translate Releases and Download pages #47524

Merged
merged 3 commits into from
Aug 22, 2024
Merged

[ru] Translate Releases and Download pages #47524

merged 3 commits into from
Aug 22, 2024

Conversation

shurup
Copy link
Member

@shurup shurup commented Aug 16, 2024

Description

Adding /releases/ and /releases/download/ pages to the Russian localisation.

Previously, I've updated the ru.toml file adding related auto-generated parts for these pages (#46387)

@shurup shurup added the language/ru Issues or PRs related to Russian language label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 16, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f82e404
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66c2c484a6838e0008f5daea
😎 Deploy Preview https://deploy-preview-47524--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shurup
[ru] Translate Releases and Download
967688e 
Signed-off-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
@shurup
Copy link
Member Author

shurup commented Aug 16, 2024

After seeing the live preview, I also made minor fixes in the abovementioned ru.toml to make things a bit better.

Arhell
Arhell reviewed Aug 17, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e29de1f89755d35189b831e45bc17779daffd50

kirkonru
kirkonru reviewed Aug 18, 2024
View reviewed changes
Copy link
Contributor

@kirkonru kirkonru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks a lot for your contribution!

@shurup @kirkonru
Update content/ru/releases/download.md
b37f71d 
Co-authored-by: Kirill Kononovich <41591254+kirkonru@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@shurup
Copy link
Member Author

shurup commented Aug 19, 2024

Thanks, @kirkonru! We're ready to merge it, but need another round of LGTM's then, please 🙏

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 19, 2024
@kirkonru
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc3d688f8d1bdecff1a48583a0011a92b7236e11

@shurup
Copy link
Member Author

shurup commented Aug 22, 2024

Hi @Arhell! Can you, please, re-LGTM this to get it merged 🙏

@Arhell
Copy link
Member

Arhell commented Aug 22, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arhell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0f49ecc into kubernetes:main Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirkonru kirkonru kirkonru left review comments

@Arhell Arhell Awaiting requested review from Arhell

Assignees

@Arhell Arhell

@kirkonru kirkonru

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ru Issues or PRs related to Russian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shurup @k8s-ci-robot @kirkonru @Arhell