Clarify Finalizer Usage and Controller Types in Background Cascading Deletion #47977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9e858d0f60d04dda7df3b91ea470c48edff5c72d
|
guettli
reviewed
Sep 18, 2024
reylejano
reviewed
Sep 18, 2024
reylejano
reviewed
Sep 18, 2024
k8s-ci-robot
removed
the
lgtm
network-charles
force-pushed
the
network-charles-patch-2
branch
from
61e2792
to
7c6bced
Compare
network-charles
commented
Sep 21, 2024
network-charles
force-pushed
the
network-charles-patch-2
branch
from
99f3ac2
to
0707636
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Hey @tengqm, could you please add the LGTM label to the PR again? |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 838c346b002efe38b045146ecea9c9e1ef423982
|
|
It's a pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR clarifies the use of finalizers during a background cascading deletion. It also clarifies what type of controllers are being referred to.
Issue
Closes: #47956