-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to ensure that ConfigMaps volume does create file(s) in container #493
Conversation
Document the fix proposed originally in: kubernetes/kubernetes#23392 (comment) Tested with: Client Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.4", GitCommit:"3eed1e3be6848b877ff80a93da3785d9034d0a4f", GitTreeState:"clean"} Server Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.4", GitCommit:"3eed1e3be6848b877ff80a93da3785d9034d0a4f", GitTreeState:"clean"}
You might want to document, in the prerequisites, that docker should be running with
|
@spiralman In my environment, i still have "MountFlags=slave" in /lib/systemd/system/docker.service So i did not want to add it. Also since there is no mention of docker-machine on that page. it does not seem appropriate to add a reference to the --make-shared command |
@dims I certainly understand about That said, the documentation as changed in this PR will not work if you follow the default instructions for installing and configuring Docker Machine, and will fail on the very first command you try to run. I think Docker Machine is widely used on developers' development machines, where they are likely to be playing with Kubernetes for the first time, and it's frustrating if the first command in the getting started guide fails with a cryptic error message. (More frustrating is I found no documentation whatsoever on how to map the There is also already a mention of docker-machine on that page, in the "Download Perhaps there should be a separate section or page documenting specific issues/caveats related to running Kubernetes inside Docker Machine? |
@spiralman - am a n00b here and this was my 2nd(?) PR :) So i'll let others comment. Also, +1 to "Perhaps there should be a separate section or page documenting specific issues/caveats related to running Kubernetes inside Docker Machine?" |
I'm afraid this issue is not limited to docker machine. Any installation of docker whose process isn't configured with non-private mount propagation is affected, and this includes installation of upstream docker on a host with systemd (explicitly sets MountFlags=private in the unit file). |
This looks good as a standalone thing. New PRs can be submitted to add more context, but this fixes the original issue. @dims Thanks for your contribution. |
* Update docsy 2021-09-21 * Revert the CSS change of kubernetes#493
* Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título
* Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título
* Update CODEOWNERS in dev-pt to sync with main * Settings and initial contents for Portuguese localization (kubernetes#343) * docs: add configs and index to content/pt * docs: add contribute and style guide to content/pt * docs: add more translated content and update index.md * doc: add i18n/pt.toml * doc: change configs to use pt-br instead of pt * docs: add style-guide in pt-br * docs: small typos in pt-br * docs: small contribute in ptbr * docs: fix markdown at style-guide Co-authored-by: Seokho Son <shsongist@gmail.com> * docs: fix weight to pt-br config Co-authored-by: Seokho Son <shsongist@gmail.com> * docs: remove i18n/pt.toml Co-authored-by: Seokho Son <shsongist@gmail.com> * Update CODEOWNDERS for dev-pt * Add content/pt-br/application_programming_interface.md (kubernetes#437) * Add content/pt-br/application_programming_interface.md Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * Add content/pt-br/blue_green_deployment.md (kubernetes#436) * Add content/pt-br/blue_green_deployment.md Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * adding client_server_architecture localization (kubernetes#480) * Add content/pt-br/bare_metal_machine.md (kubernetes#493) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Add content/pt-br/devops.md (kubernetes#478) * docs(pt-br): add content/pt-br/devops.md * Add content/pt-br/containerization.md (kubernetes#487) * docs: add containerization.md localization to ptbr * Update content/pt-br/containerization.md Co-authored-by: Jéssica Lins <jlins@redhat.com> * Update content/pt-br/containerization.md Co-authored-by: Jéssica Lins <jlins@redhat.com> * Update content/pt-br/containerization.md Co-authored-by: Jéssica Lins <jlins@redhat.com> Co-authored-by: Jéssica Lins <jlins@redhat.com> * Add content/pt-br/cluster.md (kubernetes#486) * docs: add cluster.md localization to ptbr * docs: add cluster.md localization to ptbr * Apply suggested reviews Co-authored-by: Jéssica Lins <jlins@redhat.com> Co-authored-by: Jéssica Lins <jlins@redhat.com> * Add content/pt-br/container.md (kubernetes#485) * docs: add container.md localization to ptbr * feat: improve some sentences * Add content/pt-br/cloud_native_apps.md (kubernetes#596) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add content/pt-br/cloud_native_apps.md * Add content/pt-br/container-image.md (kubernetes#557) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Add container-image.md * Remove bare_metal_machine.md * Change from registros do contêiner to repositório de imagens * api gateway localization (kubernetes#479) * Add content/pt-br/cloud_native_security.md (kubernetes#643) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Traduzido cloud_native_security * Add content/pt-br/canary_deployment.md (kubernetes#595) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add canary_deployment.md * Add content/pt-br/continuous_delivery.md (kubernetes#558) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add continuous_delivery.md * Add content/pt-br/contributor-ladder (kubernetes#662) * feat: start localization to contributor ladder * feat: add contributor ladder * docs: add more translation to contributor ladder * feat: add more translation to contributor ladder * feat: add more translation to contributor ladder * fix: fix small typos * Apply suggestions from code review Co-authored-by: Jéssica Lins <jlins@redhat.com> * feat: apply suggestions by code review * feat: change "." to ";" Co-authored-by: Jéssica Lins <jlins@redhat.com> * feat: change style guide to how to contribute and style guide (kubernetes#663) * Add content/pt-br/continuous_integration.md (kubernetes#594) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add continuous_integration.md * Sentence structure adjustment * [pt-BR] Add contributors names (kubernetes#671) * feat: add contributors * feat: add ptbr contributors * [pt-BR] Update config.toml (kubernetes#677) * feat: update config.toml with main * Settings and initial contents for Portuguese localization (kubernetes#343) * docs: add configs and index to content/pt * docs: add contribute and style guide to content/pt * docs: add more translated content and update index.md * doc: add i18n/pt.toml * doc: change configs to use pt-br instead of pt * docs: add style-guide in pt-br * docs: small typos in pt-br * docs: small contribute in ptbr * docs: fix markdown at style-guide Co-authored-by: Seokho Son <shsongist@gmail.com> * docs: fix weight to pt-br config Co-authored-by: Seokho Son <shsongist@gmail.com> * docs: remove i18n/pt.toml Co-authored-by: Seokho Son <shsongist@gmail.com> * Add content/pt-br/application_programming_interface.md (kubernetes#437) * Add content/pt-br/application_programming_interface.md Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * Add content/pt-br/blue_green_deployment.md (kubernetes#436) * Add content/pt-br/blue_green_deployment.md Signed-off-by: Jéssica Lins <jessicaalins@gmail.com> * adding client_server_architecture localization (kubernetes#480) * Add content/pt-br/bare_metal_machine.md (kubernetes#493) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Add content/pt-br/devops.md (kubernetes#478) * docs(pt-br): add content/pt-br/devops.md * Add content/pt-br/containerization.md (kubernetes#487) * docs: add containerization.md localization to ptbr * Update content/pt-br/containerization.md Co-authored-by: Jéssica Lins <jlins@redhat.com> * Update content/pt-br/containerization.md Co-authored-by: Jéssica Lins <jlins@redhat.com> * Update content/pt-br/containerization.md Co-authored-by: Jéssica Lins <jlins@redhat.com> Co-authored-by: Jéssica Lins <jlins@redhat.com> * Add content/pt-br/cluster.md (kubernetes#486) * docs: add cluster.md localization to ptbr * docs: add cluster.md localization to ptbr * Apply suggested reviews Co-authored-by: Jéssica Lins <jlins@redhat.com> Co-authored-by: Jéssica Lins <jlins@redhat.com> * Add content/pt-br/container.md (kubernetes#485) * docs: add container.md localization to ptbr * feat: improve some sentences * Add content/pt-br/cloud_native_apps.md (kubernetes#596) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add content/pt-br/cloud_native_apps.md * Add content/pt-br/container-image.md (kubernetes#557) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Add container-image.md * Remove bare_metal_machine.md * Change from registros do contêiner to repositório de imagens * api gateway localization (kubernetes#479) * Add content/pt-br/cloud_native_security.md (kubernetes#643) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Traduzido cloud_native_security * Add content/pt-br/canary_deployment.md (kubernetes#595) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add canary_deployment.md * Add content/pt-br/continuous_delivery.md (kubernetes#558) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add continuous_delivery.md * Add content/pt-br/contributor-ladder (kubernetes#662) * feat: start localization to contributor ladder * feat: add contributor ladder * docs: add more translation to contributor ladder * feat: add more translation to contributor ladder * feat: add more translation to contributor ladder * fix: fix small typos * Apply suggestions from code review Co-authored-by: Jéssica Lins <jlins@redhat.com> * feat: apply suggestions by code review * feat: change "." to ";" Co-authored-by: Jéssica Lins <jlins@redhat.com> * feat: change style guide to how to contribute and style guide (kubernetes#663) * Add content/pt-br/continuous_integration.md (kubernetes#594) * Add content/pt-br/bare_metal_machine.md * Add content/pt-br/container-image.md * Update content/pt-br/bare_metal_machine.md * Remove container-image.md * Traduzido título * Remove bare_metal_machine.md * Add continuous_integration.md * Sentence structure adjustment * [pt-BR] Add contributors names (kubernetes#671) * feat: add contributors * feat: add ptbr contributors * [pt-BR] Update config.toml (kubernetes#677) * feat: update config.toml with main * feat: translate feedback section in ptbr Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Jéssica Lins <jlins@redhat.com> Co-authored-by: Willian dos Santos <will.santos92@gmail.com> Co-authored-by: Mr. Erlison <98214640+MrErlison@users.noreply.github.com> Co-authored-by: Marcelo Mansur <mansur.ufmg@gmail.com>
Document the fix proposed originally in:
kubernetes/kubernetes#23392 (comment)
Tested with:
Client Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.4", GitCommit:"3eed1e3be6848b877ff80a93da3785d9034d0a4f", GitTreeState:"clean"}
Server Version: version.Info{Major:"1", Minor:"2", GitVersion:"v1.2.4", GitCommit:"3eed1e3be6848b877ff80a93da3785d9034d0a4f", GitTreeState:"clean"}