-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc on how to configure Kubelet with a file #5694
Add doc on how to configure Kubelet with a file #5694
Conversation
Deploy preview ready! Built with commit 16adbc1 https://deploy-preview-5694--kubernetes-io-master-staging.netlify.com |
2c8d64b
to
5411b29
Compare
is defined by the `KubeletConfiguration` struct | ||
[here (v1alpha1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1alpha1/types.go). | ||
The configuration file must be a JSON or YAML representation of the parameters | ||
in this struct. Note that that this structure, and thus the config file API, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that that -> that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
[here (v1alpha1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1alpha1/types.go). | ||
The configuration file must be a JSON or YAML representation of the parameters | ||
in this struct. Note that that this structure, and thus the config file API, | ||
is still considured alpha and is not subject to stability gurarantees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considured -> considered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Kubelet's `--init-config-dir` flag set to the location of the directory | ||
containing the `kubelet` file. The Kubelet will then load the parameters defined | ||
by `KubeletConfiguration` from the `kubelet` file, rather than from their | ||
associated command-line flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so settings in the configuration file take precedence of the command line flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
|
||
## Relationship to Dynamic Kubelet Config | ||
|
||
If you are using the [Dynamic Kubelet Configuration](https://github.com/kubernetes/features/issues/281) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest we here use the link shown above Reconfigure a Node's Kubelet in a Live Cluster. Referring to issues on github.com is not end user friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
feature, the configuration provided via `--init-config-dir` will be considered | ||
the "last known good" configuration by the automatic rollback mechanism. | ||
|
||
Note that the layout of the files in the `--init-conifg-dir` mirrors the layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: --init-config-dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Done.
5411b29
to
16adbc1
Compare
Updated PTAL |
SG, thanks Steve! |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, 👍
Follow up to #5523 that describes how to load Kubelet configuration from a file.
This change is