Add warning about using packaged kubeadm #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview ready! Built with commit eaa547a https://deploy-preview-5716--kubernetes-io-master-staging.netlify.com |
heckj
suggested changes
Oct 2, 2017
| @@ -42,6 +42,13 @@ $ curl -sSL https://dl.k8s.io/release/${VERSION}/bin/linux/${ARCH}/kubeadm > /us | |||
| $ chmod a+rx /usr/bin/kubeadm | |||
| ``` | |||
|
|
|||
| NOTE: You will notice that `kubeadm` is also shipped in the Kubernetes | |||
There was a problem hiding this comment.
Note looks good, but could you toss in the relevant format structure for it so it stands out appropriately? (from https://kubernetes.io/docs/home/contribute/style-guide/ - )
format I think you want is:
**Note:** The prefix you use is the same text you use in the tag.
{: .note} <!-- This tag must appear on a new line. -->
There was a problem hiding this comment.
+1 (possibly worth being called out with the "caution" tag rather than the "note" tag)
|
@castrojo 👋 I'd like to make some edits for wording; would you please un-check and re-check the box to allow edits from maintainers? Thanks. |
|
@zacharysarah done, ptal! |
|
@castrojo Do the changes look good? If so, I think we're ready to merge. |
|
LGTM, thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note to reinforce to users to use the upstream binary. See also #4689
This change is