Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preemption document with the new improvements added in 1.9 #6505

Merged
merged 1 commit into from
Dec 16, 2017

Conversation

bsalamat
Copy link
Member

@bsalamat bsalamat commented Nov 30, 2017

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
For 1.9 Features: set Milestone to 1.9 and Base Branch to release-1.9
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
NOTE: Please check the “Allow edits from maintainers” box (see image below) to
allow reviewers to fix problems on your patch and speed up the review process.

Please delete this note before submitting the pull request.

NOTE: After opening the PR, please un-check and re-check the "Allow edits from maintainers" box. This is a temporary workaround to address a known issue with GitHub.

Update preemption document with the new improvements added in 1.9.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2017
@bsalamat bsalamat changed the base branch from release-1.9 to master November 30, 2017 02:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 30, 2017
@bsalamat
Copy link
Member Author

cc/ @davidopp

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 9f01370

https://deploy-preview-6505--kubernetes-io-vnext-staging.netlify.com

pending Pod possible. In a future Kubernetes release, priority will also affect
out-of-resource eviction ordering on the Node.
pending Pod possible. In Kubernetes 1.9 and later, Priority also affects scheduling
order of pods and out-of-resource eviction ordering on the Node.

**Note:** Preemption does not respect PodDisruptionBudget; see
[the limitations section](#poddisruptionbudget-is-not-supported) for more details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this limitation still valid?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, there is a new subsection on this topic. We can remove the note here then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I will delete this note.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 8bbbcca

https://deploy-preview-6505--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2017
@bsalamat bsalamat changed the base branch from master to release-1.9 December 11, 2017 17:42
@Bradamant3 Bradamant3 added this to the 1.9 milestone Dec 11, 2017
@bsalamat
Copy link
Member Author

/assign @steveperry-53

@bsalamat
Copy link
Member Author

ping! Can we have this doc merged sooner? Some of our users are waiting for the doc to be merged to try the feature.

@tengqm
Copy link
Contributor

tengqm commented Dec 15, 2017

/cc @zacharysarah

@zacharysarah
Copy link
Contributor

zacharysarah commented Dec 15, 2017

@bsalamat 👋 The docs are planned to go live this afternoon, in a few hours.

Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharysarah
Copy link
Contributor

Changing base to master post-1.9 release

@zacharysarah zacharysarah changed the base branch from release-1.9 to master December 16, 2017 03:06
@zacharysarah zacharysarah merged commit 4c69ef9 into kubernetes:master Dec 16, 2017
@bsalamat bsalamat deleted the preemption branch December 18, 2017 19:24
chenopis added a commit that referenced this pull request Dec 20, 2017
…henopis-user-journeys

* 'master' of https://github.com/kubernetes/website: (92 commits)
  Update partner-script.js (#6570)
  Update redirects for kubectl commands. (#6706)
  Improve redirection of 1.8 ref docs. (#6705)
  Modify Service Catalog snippet long description
  add prepend option to glossary definition tag
  Mark CPU manager feature as beta for v1.10.
  Balaji, Seth, Connor as CPU manager doc approvers.
  Fix broken link (#6691)
  Clarify that StatefulSet is stable in 1.9 (#6697)
  Update coredns.md (#6698)
  Update preemption document with the new improvements added in 1.9 (#6505)
  v1.9 patch (#6690)
  Remove 1.9 info from the PR template
  Fix release 1.9 (#6686)
  Release 1.9 (#5978)
  [maintenance] December link fixes (#6680)
  Update audit.md (#6381)
  Fixed typo
  concepts/policy/pod-security-policy.md: fix broken links.
  Fixed a typo `illgal`
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants