-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document AllowedFlexVolumes in PSP #6967
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit ed2dd9d https://deploy-preview-6967--kubernetes-io-master-staging.netlify.com |
@@ -28,6 +28,7 @@ administrator to control the following: | |||
| Usage of host networking and ports | [`hostNetwork`, `hostPorts`](#host-namespaces) | | |||
| Usage of volume types | [`volumes`](#volumes-and-file-systems) | | |||
| Usage of the host filesystem | [`allowedHostPaths`](#volumes-and-file-systems) | | |||
| Usage of FlexVolume drivers | [`allowedFlexVolumes](#flexvolume-drivers) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a backtick at the end of allowedFelxVolumes
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ... will fix.
|
||
**AllowedFlexVolumes** - Provides a whitelist of allowed FlexVolumes. Empty or | ||
nil indicates that all FlexVolume drivers may be used. For example, the following | ||
setting permits the `examle/fast_cache` driver to be used on nodes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "permits the" correct, or is "only permits the" more accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right.
@heckj fixed. |
/lgtm |
I have couple questions:
|
setting only permits the `examle/fast_cache` driver to be used on nodes: | ||
|
||
```yaml | ||
allowedFlexVolumes: [ "example/fast_cache" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this example incorrect and won't work :-|
allowedFlexVolumes
accepts list of the objects (not list of the strings). See correct example in the original PR from @wanghaoran1988
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault. It should be a list of objects where each object has a driver property. Will fix.
Closes: #6447
This change is