Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated rkt guide #7376

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Remove outdated rkt guide #7376

merged 1 commit into from
Feb 12, 2018

Conversation

errordeveloper
Copy link
Member

@errordeveloper errordeveloper commented Feb 12, 2018 •
edited by k8s-reviewable
Loading

Closes #7279. Ping #7278.

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 12, 2018
@errordeveloper errordeveloper mentioned this pull request Feb 12, 2018
Closed
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f1ff786

https://deploy-preview-7376--kubernetes-io-master-staging.netlify.com

@errordeveloper
Copy link
Member Author

/assign @yifan-gu

@errordeveloper errordeveloper mentioned this pull request Feb 12, 2018
Closed
@heckj
Copy link
Contributor

heckj commented Feb 12, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2018
@errordeveloper
Copy link
Member Author

@heckj as it's a deletion, do I still need an LGTM from someone?

@heckj
Copy link
Contributor

heckj commented Feb 12, 2018

yeah - since you commented to @yifan-gu, i was thinking they would apply it, but if that was just for info i can add it here. wasn’t sure about your intent

@errordeveloper
Copy link
Member Author

errordeveloper commented Feb 12, 2018 via email •
edited
Loading

@heckj
Copy link
Contributor

heckj commented Feb 12, 2018

got it
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: errordeveloper, heckj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 36de075 into kubernetes:master Feb 12, 2018
@errordeveloper errordeveloper deleted the gsg-cleanup-rkt branch February 13, 2018 12:04
tehut pushed a commit to tehut/website that referenced this pull request Feb 20, 2018
@errordeveloper @tehut
Remove outdated rkt guide (kubernetes#7376)
f7f70b4
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Feb 23, 2018
@errordeveloper @bsalamat
Remove outdated rkt guide (kubernetes#7376)
1623c2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@zhangxiaoyu-zidif zhangxiaoyu-zidif Awaiting requested review from zhangxiaoyu-zidif

Assignees

@heckj heckj

@yifan-gu yifan-gu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@errordeveloper @k8sio-netlify-preview-bot @heckj @k8s-ci-robot @yifan-gu