update kubeletconfig docs for v1.10, beta #7561

mtaufen · 2018-02-28T17:53:19Z

updates the docs for v1.10, where the loading config from a file feature is now beta

mtaufen · 2018-02-28T17:54:16Z

/assign @tengqm

mtaufen · 2018-02-28T17:54:27Z

/milestone v1.10

k8sio-netlify-preview-bot · 2018-02-28T17:55:32Z

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 31803f9

https://deploy-preview-7561--kubernetes-io-master-staging.netlify.com

mtaufen · 2018-02-28T18:44:31Z

@chenopis any idea why it says FEATURE STATE: Kubernetes v1.9 in the preview? This should be for 1.10.

mtaufen · 2018-02-28T18:56:44Z

need to fix this up to target the 1.10 branch, will retry

k8s-ci-robot · 2018-02-28T18:57:54Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chenopis · 2018-02-28T18:58:06Z

Since this is for v1.10, I'm going to
/assign @Bradamant3

k8sio-netlify-preview-bot · 2018-02-28T19:00:50Z

Deploy preview for kubernetes-io-vnext-staging ready!

Built with commit eef9d77

https://deploy-preview-7561--kubernetes-io-vnext-staging.netlify.com

xiangpengzhao · 2018-03-01T01:54:47Z

docs/tasks/administer-cluster/kubelet-config-file.md

@@ -27,10 +30,9 @@ providing parameters via a config file, which simplifies node deployment.

 The subset of the Kubelet's configuration that can be configured via a file
 is defined by the `KubeletConfiguration` struct
-[here (v1alpha1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1alpha1/types.go).
+[here (v1beta1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go).
 The configuration file must be a JSON or YAML representation of the parameters


It'd be good to provide an example of the config file. Then users/administrators can write their own config file easily. @mtaufen WDYT?

From a user's perspective, I'm always not confident enough to write such files without an example :)

I agree, we should have an example. Should not block this PR though. I can write an example on Monday when I'm back at work (OOO next two days).

^ I can add a small example tonight, and a more complete one later

Added a very small example file.

xiangpengzhao · 2018-03-01T01:55:44Z

docs/tasks/administer-cluster/kubelet-config-file.md

-`kubelet:KubeletConfiguration`, though more may emerge in the future.
-See [Reconfigure a Node's Kubelet in a Live Cluster](/docs/tasks/administer-cluster/reconfigure-kubelet)
-for more information.
+feature, the combination of flags and configuration provided via `--config` 


The combination means Note that command line flags which target the same value as a config file will override that value. mentioned above, right?

CaoShuFeng · 2018-03-01T03:27:25Z

docs/tasks/administer-cluster/kubelet-config-file.md

@@ -27,10 +30,9 @@ providing parameters via a config file, which simplifies node deployment.

 The subset of the Kubelet's configuration that can be configured via a file
 is defined by the `KubeletConfiguration` struct
-[here (v1alpha1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1alpha1/types.go).
+[here (v1beta1)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go).


Permalink is perferred, I think.
https://github.com/kubernetes/kubernetes/blob/release-1.10/pkg/kubelet/apis/kubeletconfig/v1beta1/types.go

mtaufen · 2018-03-01T04:18:22Z

A few more things in the reconfigure-kubelet doc need to be updated as well.

tengqm

Overall lgtm. some nits for consideration if there will be another iteration. Thanks.

tengqm · 2018-03-01T04:21:57Z

docs/tasks/administer-cluster/kubelet-config-file.md

+This functionality is considered beta in v1.10.
+
+Most of the existing command-line flags are deprecated in favor of providing
+parameters via a config file, which simplifies node deployment.


This statement is a little bit confusing to readers if they are not aware of such 'existing command line flags'.
A different way to put it would be just state the current status. For example, "Providing parameters via a config file is the recommended approach because it simplifies node deployment and configuration management."

tengqm · 2018-03-01T04:24:34Z

docs/tasks/administer-cluster/kubelet-config-file.md

-containing the `kubelet` file. The Kubelet will then load the parameters defined
-by `KubeletConfiguration` from the `kubelet` file, rather than from their 
-associated command-line flags.
+Start the Kubelet with the `--config` flag set to the filepath of the Kubelet's config file.


"filepath" -> "path"

tengqm · 2018-03-01T04:27:15Z

docs/tasks/administer-cluster/reconfigure-kubelet.md

 ```

 Note that we have to manually add the `kind` and `apiVersion` to the downloaded
 object, as these are not reported by the configz endpoint. This is one of the
 limitations of the endpoint that is planned to be fixed in the future.
+If you are using a Kubelet less than v1.10, you must substitute `v1alpha1` for `{VERSION}`.
+If you are using a Kubelet v1.10 or higher, you must substitute `v1beta1` for `{VERSION}`.


You may want to remove the curly brackets above.

Do we have a standard format for "values the user should mentally substitute?"

xiangpengzhao · 2018-03-01T12:15:47Z

docs/tasks/administer-cluster/kubelet-config-file.md

+Here is an example of what this file might look like:
+```
+kind: KubeletConfiguration
+apiVersion: kubeletconfig/v1beta1


Shouldn't this be kubelet.config.k8s.io/v1beta1 ?

oops, fixed, thanks

xiangpengzhao · 2018-03-02T01:48:42Z

LGTM

heckj · 2018-03-03T19:49:56Z

/approve
/lgtm

k8s-ci-robot · 2018-03-03T19:50:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [heckj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* 1.10 update (#7151) * Fix partition value expected behaviour explanation (#7123) Fixes issue #7057 * Correct "On-Premise" to "On-Premises" * Updates the Calico installation page (#7094) * All files for Haufe Groups case study (#7051) * Fix typo (#7127) * fix typo of device-plugins.md (#7106) * fix broken links (#7136) * Updated configure-service-account (#7147) Error from server resolved by escaping kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "myregistrykey"}]}' JSON string by '\' * Remove docs related to 'require-kubeconfig' (#7138) With kubernetes/kubernetes#58367 merged, v1.10 will not use the "require-kubeconfig" flag. The flag has become a no-op solely to ensure existing deployments won't break. * Added Verification Scenario for a Pod that Uses a PVC in Terminating State (#7164) The below PR: kubernetes/kubernetes#55873 modified scheduler in such a way that scheduling of a pod that uses a PVC in Terminating state fails. That's why verification of such scenario was added to documentation. * fix LimitPodHardAntiAffinityTopology name (#7221) * Document the removal of the KubeletConfigFile feature gate (#7140) With kubernetes/kubernetes#58978 merged, the said feature gate is removed. This PR removes texts related to the gate and revises the Feature Gates reference to reflect this change. * deprecate three admission controller (#7363) * Document the removal of Accelerators feature gate (#7389) The `Accelerators` feature gate will be removed in 1.11. 1.10 will be its last mile. References: kubernetes/kubernetes#57384 * Update local storage docs for beta (#7473) * Document that HugePages feature gate is Beta (#7387) The `HugePages` feature gate has graduated to Beta in v1.10. This PR documents this fact. * Add HyperVContainer feature gates (#7502) * Remove the beta reference from Taints and Tolerations doc (#7493) * Kms provider doc (#7479) * Kms provider doc * issue# 7399, Create KMS-provider.md and update encrypt-data.md * address review comments * Document that Device Plugin feature is Beta (1.10) (#7512) * Add docs for CRD features for 1.10 (#7439) * Add docs for CRD features for 1.10 * Add CustomResourcesSubresources to list of feature gates * Add latest changes to custom resources doc * Add crds as abbreviated alias (#7437) * Bring PVC Protection Feature to Beta (#7165) * Bring PVC Protection Feature to Beta The PR: kubernetes/kubernetes#59052 brought PVC Protection feature to beta. That's why the documentation is updated accordingly. * The PVC Protection feature was renamed to Storage Protection. That's why the documentation is updated. * promote PodNodeSelector to stable; document detailed behavior (#7134) * promote PodNodeSelector to stable; document detailed behavior * respond to feedback * Update CPU manager feature enabling (#7390) With `CPUManager` feature graduating to beta. No explicit enabling is required starting v1.10. References: kubernetes/kubernetes#55977 * Adding block volumeMode documentation for local volumes. (#7531) Code review comments. Changed property to field. Address tech review comment. * remove description kubectl --show-all (#7574) --show-all has been deprecated and set to true by default. kubernetes/kubernetes#60210 * fix description about contribute style guide (#7592) * fix description about KUBECONFIG (#7589) s/envrionment/environment * fix description about cni (#7588) s/simultanously/simultaneously/ * fix description about MutatingAdmissionWebhook and ValidatingAdmissionWebhook (#7587) * fix description about persistent volume binding (#7590) s/slighty/slightly/ * Doc change for configurable pod resolv.conf Beta (#7611) * fix description about out of resource handling (#7597) s/threshhold/threshold * fix description about zookeeper (#7598) s/achive/achieve * fix description about kubeadm (#7594) s/compatability/compatibility/ * fix description about kubeadm (#7593) * fix description about kubeadm implementation details (#7595) * fix description about api concepts (#7596) * Storage Protection was renamed to Storage Object in Use Protection (#7576) * Storage Protection was renamed to Storage Object in Use Protection The K8s PR: kubernetes/kubernetes#59901 renamed Storage Protection to Storage Object in Use Protection. That's why the same is also renamed in the documentation. * Moved Storage Object in Use Protection admission plugin description down according to alphabetic order. * Use PSP from policy API group. (#7562) * update kubeletconfig docs for v1.10, beta (#7561) * Update port-forwarding docs (#7575) * add pv protection description (#7620) * fix description about client library (#7634) * Add docs on configuring NodePort IP (#7631) * Document that LocalStorageCapacityIsolation is beta (#7635) A follow-up to the kubernetes/kubernetes#60159 change which has promoted the `LocalStorageCapacityIsolation` feature gate to Beta. * Update CoreDNS docs for beta (#7638) * Update CoreDNS docs for beta * Review comments * Fix typo (#7640) * Update feature gates move to beta (#7662) * Added the inability to use colon ':' character as environment variable names and described workaround (#7657) * merge master to 1.10, with fixes (#7682) * Flag names changed (s/admission-control/enable-admission-plugins); disable-admissions-plugin entry added; removed reference to admission controller/plugins requiring set order (for v1.10), redundant example enabling specific plugin, and redundant version-specific info (#7449) * Documentation for MountPropagation beta (#7655) * Remove job's scale-related operations (#7684) * authentication: document client-go exec plugins (#7648) * authentication: document client-go exec plugins * Update authentication.md * Update local ephemeral storage feature to beta (#7685) Update local ephemeral storage feature to beta * Update docs for windows container resources (#7653) * add server-side print docs (#7671) * Create a task describing Pod process namespace sharing (#7489) * Add external metrics to HPA docs (#7664) * Add external metrics to HPA docs * Update horizontal-pod-autoscale-walkthrough.md * Apply review comments to HPA walkthrough * remove description about "scale jobs" (#7712) * CSI Docs for K8s v1.10 (#7698) * Add a warning about increased memory consumption for audit logging feature. (#7725) Signed-off-by: Mik Vyatskov <vmik@google.com> * Update Audit Logging documentation for 1.10 (#7679) Signed-off-by: Mik Vyatskov <vmik@google.com> * Fix stage names in audit logging documentation (#7746) Signed-off-by: Mik Vyatskov <vmik@google.com> * Feature gate update for release 1.10 (#7742) * State in the docs that the value of default Node labels are not reliable. (#7794) * Kill the reference to --admission-control option (#7755) The `--admission-control` option has been replaced by two new options in v1.10. This PR kills the last appearance of the old option in the doc. * Pvcprotection toc (#7807) * Refreshing installation instructions (#7495) * Refreshing installation instructions Added conjure-up. Updated displays and juju versions to current versions. * Updated anchors * Fixed image value version typo (#7768) Was inconsistent with other values * Update flocker reference to the github repo (#7784) * Fix typo in federation document (#7779) * an user -> a user (#7778) * Events are namespaced (#7767) * fix 'monitoring' link lose efficacy problem' (#7764) * docs/concepts/policy/pod-security-policy.md: minor fix. (#7659) * Update downward-api-volume-expose-pod-information.md (#7771) * Update downward-api-volume-expose-pod-information.md The pod spec puts the downward api files into /etc/podinfo, not directly in /etc. Updated docs to reflect this fact. * Update downward-api-volume-expose-pod-information.md One more spot needed fixing. * Update downward-api-volume-expose-pod-information.md Yet another fix, in the container example. * Add Amadeus Case Study (#7783) * Add Amadeus Case Study * add Amadeus logo * Fixed Cyrillic с in 'kube-proxy-cm' (#7787) There was a typo (wrong character) in kube-proxy-cm.yaml - Cyrillic с (UTF-8 0x0441) was used instead of Latin c. * install-kubectl: choose one installation method (#7705) The previous text layout suggested that all installations had to be done, one after another. * Update install-kubeadm.md (#7781) Add note to kubeadm install instruction to help install in other arch i.e. aarch64, ppc64le etc. * repair failure link (#7788) * repair failure link * repair failure link * do change as required * Update k8s201.md (#7777) * Update k8s201.md Change instructions to download yams files directly from the website (as used in other pages.) Added instructions to delete labeled pod to avoid warnings in the subsequent deployment step. * Update k8s201.md Added example of using the exposed host from the a node running Kubernetes. (This works on AWS with Weave; not able to test it on other variations...) * Gramatical fix to kompose introduction (#7792) The original wording didn't through very well. As much of the original sentence has been preserved as possible, primarily to ensure the kompose web address is see both in text and as a href link. * update amadeus.html (#7800) * Fix a missing word in endpoint reconciler section (#7804) * add toc entry for pvcprotection downgrade issue doc * Pvcprotection toc (#7809) * Refreshing installation instructions (#7495) * Refreshing installation instructions Added conjure-up. Updated displays and juju versions to current versions. * Updated anchors * Fixed image value version typo (#7768) Was inconsistent with other values * Update flocker reference to the github repo (#7784) * Fix typo in federation document (#7779) * an user -> a user (#7778) * Events are namespaced (#7767) * fix 'monitoring' link lose efficacy problem' (#7764) * docs/concepts/policy/pod-security-policy.md: minor fix. (#7659) * Update downward-api-volume-expose-pod-information.md (#7771) * Update downward-api-volume-expose-pod-information.md The pod spec puts the downward api files into /etc/podinfo, not directly in /etc. Updated docs to reflect this fact. * Update downward-api-volume-expose-pod-information.md One more spot needed fixing. * Update downward-api-volume-expose-pod-information.md Yet another fix, in the container example. * Add Amadeus Case Study (#7783) * Add Amadeus Case Study * add Amadeus logo * Fixed Cyrillic с in 'kube-proxy-cm' (#7787) There was a typo (wrong character) in kube-proxy-cm.yaml - Cyrillic с (UTF-8 0x0441) was used instead of Latin c. * install-kubectl: choose one installation method (#7705) The previous text layout suggested that all installations had to be done, one after another. * Update install-kubeadm.md (#7781) Add note to kubeadm install instruction to help install in other arch i.e. aarch64, ppc64le etc. * repair failure link (#7788) * repair failure link * repair failure link * do change as required * Update k8s201.md (#7777) * Update k8s201.md Change instructions to download yams files directly from the website (as used in other pages.) Added instructions to delete labeled pod to avoid warnings in the subsequent deployment step. * Update k8s201.md Added example of using the exposed host from the a node running Kubernetes. (This works on AWS with Weave; not able to test it on other variations...) * Gramatical fix to kompose introduction (#7792) The original wording didn't through very well. As much of the original sentence has been preserved as possible, primarily to ensure the kompose web address is see both in text and as a href link. * update amadeus.html (#7800) * Fix a missing word in endpoint reconciler section (#7804) * add toc entry for pvcprotection downgrade issue doc * revert TOC change * Release 1.10 (#7818) * Refreshing installation instructions (#7495) * Refreshing installation instructions Added conjure-up. Updated displays and juju versions to current versions. * Updated anchors * Fixed image value version typo (#7768) Was inconsistent with other values * Update flocker reference to the github repo (#7784) * Fix typo in federation document (#7779) * an user -> a user (#7778) * Events are namespaced (#7767) * fix 'monitoring' link lose efficacy problem' (#7764) * docs/concepts/policy/pod-security-policy.md: minor fix. (#7659) * Update downward-api-volume-expose-pod-information.md (#7771) * Update downward-api-volume-expose-pod-information.md The pod spec puts the downward api files into /etc/podinfo, not directly in /etc. Updated docs to reflect this fact. * Update downward-api-volume-expose-pod-information.md One more spot needed fixing. * Update downward-api-volume-expose-pod-information.md Yet another fix, in the container example. * Add Amadeus Case Study (#7783) * Add Amadeus Case Study * add Amadeus logo * Fixed Cyrillic с in 'kube-proxy-cm' (#7787) There was a typo (wrong character) in kube-proxy-cm.yaml - Cyrillic с (UTF-8 0x0441) was used instead of Latin c. * install-kubectl: choose one installation method (#7705) The previous text layout suggested that all installations had to be done, one after another. * Update install-kubeadm.md (#7781) Add note to kubeadm install instruction to help install in other arch i.e. aarch64, ppc64le etc. * repair failure link (#7788) * repair failure link * repair failure link * do change as required * Update k8s201.md (#7777) * Update k8s201.md Change instructions to download yams files directly from the website (as used in other pages.) Added instructions to delete labeled pod to avoid warnings in the subsequent deployment step. * Update k8s201.md Added example of using the exposed host from the a node running Kubernetes. (This works on AWS with Weave; not able to test it on other variations...) * Gramatical fix to kompose introduction (#7792) The original wording didn't through very well. As much of the original sentence has been preserved as possible, primarily to ensure the kompose web address is see both in text and as a href link. * update amadeus.html (#7800) * Fix a missing word in endpoint reconciler section (#7804) * Partners page updates (#7802) * Partners page updates * Update to ZTE link * Make using sysctls a task instead of a concept (#6808) Closes: #4505 * add a note when mount a configmap to pod (#7745) * adjust a note format (#7812) * Update docker-cli-to-kubectl.md (#7748) * Update docker-cli-to-kubectl.md Edited the document for adherence to the style guide and word usage. * Update docker-cli-to-kubectl.md * Incorporated the changes suggested. * Mount propagation update to include docker config (#7854) * update overridden config for 1.10 (#7847) * update overridden config for 1.10 * fix config file per comments * Update Extended Resource doc wrt cluster-level resources (#7759)

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2018

k8s-ci-robot requested review from tengqm and xiangpengzhao February 28, 2018 17:53

k8s-ci-robot assigned tengqm Feb 28, 2018

mtaufen mentioned this pull request Feb 28, 2018

Update kubelet-config-file.md #7560

Closed

mtaufen changed the base branch from master to release-1.10 February 28, 2018 18:55

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2018

chenopis added this to the 1.10 milestone Feb 28, 2018

k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2018

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 28, 2018

k8s-ci-robot assigned Bradamant3 Feb 28, 2018

mtaufen force-pushed the kubeletconfig-docs branch from 31803f9 to 538c276 Compare February 28, 2018 18:59

xiangpengzhao reviewed Mar 1, 2018

View reviewed changes

mtaufen mentioned this pull request Mar 1, 2018

fix kubeletconfig API description #7568

Closed

CaoShuFeng reviewed Mar 1, 2018

View reviewed changes

mtaufen force-pushed the kubeletconfig-docs branch from 538c276 to edf399a Compare March 1, 2018 03:55

tengqm reviewed Mar 1, 2018

View reviewed changes

mtaufen force-pushed the kubeletconfig-docs branch from edf399a to e8393d5 Compare March 1, 2018 04:30

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2018

mtaufen force-pushed the kubeletconfig-docs branch from e8393d5 to f5ae314 Compare March 1, 2018 04:34

xiangpengzhao reviewed Mar 1, 2018

View reviewed changes

update kubeletconfig docs for v1.10, beta

eef9d77

mtaufen force-pushed the kubeletconfig-docs branch from f5ae314 to eef9d77 Compare March 1, 2018 22:55

k8s-ci-robot assigned heckj Mar 3, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2018

k8s-ci-robot merged commit c431b28 into kubernetes:release-1.10 Mar 3, 2018

This was referenced Mar 6, 2018

Update link for kubelet configuration struct #7663

Closed

Update KubeletConfig doc to reference the release-1.9 code base #7696

Merged

zacharysarah pushed a commit that referenced this pull request Apr 16, 2018

update kubeletconfig docs for v1.10, beta (#7561)

9e96858

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update kubeletconfig docs for v1.10, beta #7561

update kubeletconfig docs for v1.10, beta #7561

mtaufen commented Feb 28, 2018

mtaufen commented Feb 28, 2018

mtaufen commented Feb 28, 2018

k8sio-netlify-preview-bot commented Feb 28, 2018

mtaufen commented Feb 28, 2018 •

edited

Loading

mtaufen commented Feb 28, 2018

k8s-ci-robot commented Feb 28, 2018

chenopis commented Feb 28, 2018

k8sio-netlify-preview-bot commented Feb 28, 2018 •

edited

Loading

xiangpengzhao Mar 1, 2018

xiangpengzhao Mar 1, 2018

mtaufen Mar 1, 2018

mtaufen Mar 1, 2018

mtaufen Mar 1, 2018

xiangpengzhao Mar 1, 2018

mtaufen Mar 1, 2018

CaoShuFeng Mar 1, 2018

mtaufen Mar 1, 2018

mtaufen commented Mar 1, 2018

tengqm left a comment

tengqm Mar 1, 2018

mtaufen Mar 1, 2018

tengqm Mar 1, 2018

mtaufen Mar 1, 2018

tengqm Mar 1, 2018

mtaufen Mar 1, 2018 •

edited

Loading

xiangpengzhao Mar 1, 2018

mtaufen Mar 1, 2018

xiangpengzhao commented Mar 2, 2018

heckj commented Mar 3, 2018

k8s-ci-robot commented Mar 3, 2018

update kubeletconfig docs for v1.10, beta #7561

update kubeletconfig docs for v1.10, beta #7561

Conversation

mtaufen commented Feb 28, 2018

mtaufen commented Feb 28, 2018

mtaufen commented Feb 28, 2018

k8sio-netlify-preview-bot commented Feb 28, 2018

mtaufen commented Feb 28, 2018 • edited Loading

mtaufen commented Feb 28, 2018

k8s-ci-robot commented Feb 28, 2018

chenopis commented Feb 28, 2018

k8sio-netlify-preview-bot commented Feb 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtaufen commented Mar 1, 2018

tengqm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtaufen Mar 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xiangpengzhao commented Mar 2, 2018

heckj commented Mar 3, 2018

k8s-ci-robot commented Mar 3, 2018

mtaufen commented Feb 28, 2018 •

edited

Loading

k8sio-netlify-preview-bot commented Feb 28, 2018 •

edited

Loading

mtaufen Mar 1, 2018 •

edited

Loading