Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated documentation about secret key validation. #7675

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Update outdated documentation about secret key validation. #7675

merged 1 commit into from
Mar 23, 2018

Conversation

af-inet
Copy link
Contributor

@af-inet af-inet commented Mar 8, 2018 •
edited
Loading

Fixes an issue with k8s.io/docs/concepts/configuration/secret/ regarding secret key validation

see: #7674, kubernetes/kubernetes#59516

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1717389

https://deploy-preview-7675--kubernetes-io-master-staging.netlify.com

@af-inet
Copy link
Contributor Author

af-inet commented Mar 8, 2018

/assign @a-mccarthy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 8, 2018
@steveperry-53
Copy link
Contributor

/assign

@steveperry-53
Copy link
Contributor

/approve (for writing)
Still need /lgtm for technical accuracy.
/cc @caesarxuchao
/cc @huangjiuyuan

@k8s-ci-robot
Copy link
Contributor

@steveperry-53: GitHub didn't allow me to request PR reviews from the following users: huangjiuyuan.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/approve (for writing)
Still need /lgtm for technical accuracy.
/cc @caesarxuchao
/cc @huangjiuyuan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2018
@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

/lgtm

(verified)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: heckj, steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [heckj,steveperry-53]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 418a44a into kubernetes:master Mar 23, 2018
chenopis added a commit that referenced this pull request Mar 27, 2018
@chenopis
Merge branch 'master' of https://github.com/kubernetes/website into r…
d97a9cf 
…elease-1.9

* 'master' of https://github.com/kubernetes/website: (549 commits)
  Update service.md (#7810)
  Prune inactive maintainers (#7830)
  add Amadeus to index page and add feature image (#7827)
  Update conventions.md (#7668)
  Adding Tenxcloud as KCSP and Hedvig typo (#7826)
  Update outdated documentation about secret key validation. (#7675)
  Update imperative-command.md (#7699)
  Update manage-deployment.md (#7774)
  Add the OCI runtime description. (#7769)
  fix flag (#7814)
  fix flag (#7813)
  Add files via upload (#7816)
  Remove CoreOS guide that use Kubernetes v0.15.0 (#7821)
  "Nagions" should be "Nagios“ (#7762)
  Update docker-cli-to-kubectl.md (#7748)
  adjust a note format (#7812)
  add a note when mount a configmap to pod (#7745)
  Make using sysctls a task instead of a concept (#6808)
  Partners page updates (#7802)
  Fix a missing word in endpoint reconciler section (#7804)
  ...
@af-inet af-inet mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@xiangpengzhao xiangpengzhao Awaiting requested review from xiangpengzhao

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@heckj heckj

@steveperry-53 steveperry-53

@a-mccarthy a-mccarthy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@af-inet @k8s-ci-robot @k8sio-netlify-preview-bot @steveperry-53 @heckj @a-mccarthy