Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CoreOS baremetal offline setup guideline #7819

Closed
wants to merge 1 commit into from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 23, 2018

The contents in this page is very old. The links in this page points to
some repos that no longer exist. This PR removes the guideline from
website.

However, considering that there may still be valuable information in the
page and there may be desire to resurrect the guide. The content is now
moved into an attic directory. We can decide whether and when to
completely drop it later.

Related: #7785

The contents in this page is very old. The links in this page points to
some repos that no longer exist. This PR removes the guideline from
website.

However, considering that there may still be valuable information in the
page and there may be desire to resurrect the guide. The content is now
moved into an attic directory. We can decide whether and when to
completely drop it later.

Related: kubernetes#7785
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 23, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bradamant3

Assign the PR to them by writing /assign @bradamant3 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 23, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 0c71deb

https://deploy-preview-7819--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor Author

tengqm commented Mar 23, 2018

@xiangpengzhao xiangpengzhao removed their request for review March 23, 2018 03:34
@errordeveloper
Copy link
Member

Thanks! I also happen to encounter this page today, and surprised I've not seen it's so old earlier when I was go through all of these guides.

I've actually opened #7821 just now to delete these outdated pages.

I don't think there is a need to move this to a directory, as we can always look at git history if needed. Anything unique about this content is going to be of very little use, because it's so old! Rewriting from scratch would be far less work then trying to adopt this for anything.

Also, we don't have an attic directory right now, I wouldn't introduce it just for this one thing. It's easier to look in git, if someone wants to resurrect any information.

@errordeveloper
Copy link
Member

errordeveloper commented Mar 23, 2018

/assign @heckj

hey @heckj, would you mind to make a call on whether we should move ahead with this or #7821 instead?

@heckj
Copy link
Contributor

heckj commented Mar 23, 2018

I went ahead and approved #7821 so that should be merged and these pages removed.
closing this one as redundant

(worked through the queue in reverse order)

@heckj heckj closed this Mar 23, 2018
@tengqm tengqm deleted the rm-coreos-baremetal branch July 18, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants