Skip to content

Commit

Permalink
ci: Allow multiplatform build targeting specific ARM architectures
Browse files Browse the repository at this point in the history
There is an issues with Node v19+ and arm based images. It is described
in nodejs/docker-node#1794 and
nodejs/docker-node#1335. At this moment it works
with v18 based images and so I downgraded to it.
  • Loading branch information
f1ames committed Nov 6, 2023
1 parent 5d76219 commit c15e379
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
uses: docker/build-push-action@v5
with:
context: ./admission-controller/${{ matrix.from }}/
platforms: linux/amd64,linux/arm64
platforms: linux/amd64,linux/arm64,linux/arm/v6,linux/arm/v7,linux/arm64/v8
file: ./admission-controller/${{ matrix.from }}/Dockerfile
tags: |
kubeshop/monokle-admission-controller-${{ matrix.from }}:latest
Expand Down
4 changes: 2 additions & 2 deletions admission-controller/init/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG BUILD_IMAGE="node:20.8-alpine"
ARG PRODUCTION_IMAGE="node:20.8-alpine"
ARG BUILD_IMAGE="node:lts-alpine3.16"
ARG PRODUCTION_IMAGE="node:lts-alpine3.16"

#####################
# Compile container
Expand Down
4 changes: 2 additions & 2 deletions admission-controller/server/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG BUILD_IMAGE="node:20.8-alpine"
ARG PRODUCTION_IMAGE="node:20.8-alpine"
ARG BUILD_IMAGE="node:lts-alpine3.16"
ARG PRODUCTION_IMAGE="node:lts-alpine3.16"

#####################
# Compile container
Expand Down
4 changes: 2 additions & 2 deletions admission-controller/synchronizer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG BUILD_IMAGE="node:20.8-alpine"
ARG PRODUCTION_IMAGE="node:20.8-alpine"
ARG BUILD_IMAGE="node:lts-alpine3.16"
ARG PRODUCTION_IMAGE="node:lts-alpine3.16"

#####################
# Compile container
Expand Down

0 comments on commit c15e379

Please sign in to comment.