Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix mapping of validation action for synchronized bindings #25

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Jan 4, 2024

This PR fixes mapping of validation action when synchronized from Cloud.

Important: This shouldn't be released as long as API changes from https://github.com/kubeshop/monokle-saas/pull/2324 are not in production, because then graphql query will break due to missing action property.

Changes

  • As above.

Fixes

  • As above.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames force-pushed the f1ames/fix/validation-action-sync branch 3 times, most recently from 26de90a to 493ec65 Compare January 4, 2024 11:02
@f1ames f1ames force-pushed the f1ames/fix/validation-action-sync branch from 493ec65 to bb6eae2 Compare January 4, 2024 11:10
@f1ames f1ames marked this pull request as ready for review January 4, 2024 11:20
@f1ames f1ames requested a review from WitoDelnat January 4, 2024 11:20
@f1ames f1ames merged commit 67041aa into main Jan 4, 2024
17 checks passed
@f1ames f1ames deleted the f1ames/fix/validation-action-sync branch January 4, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants