Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin skaffold version and change installation method #27

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Jan 18, 2024

This PR pins skaffold to previous version (2.9.0) because it started failing with latest one (2.10.0), for example: https://github.com/kubeshop/monokle-admission-controller/actions/runs/7569302057/job/20612383533#step:7:18.

Changes

  • As above.

Fixes

  • As above.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@f1ames f1ames marked this pull request as ready for review January 18, 2024 12:42
@f1ames
Copy link
Contributor Author

f1ames commented Jan 18, 2024

Merging since this is quite minor change.

@f1ames f1ames merged commit a65235c into main Jan 18, 2024
17 checks passed
@f1ames f1ames deleted the f1ames/fix/skaffold-ci branch January 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant