Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace Skopeo with Crane for image inspection #5692

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

  • We were using Skopeo binary for inspecting the images
  • Instead, replaced it with Crane that have Golang interface
  • Thanks to that, we avoid having a dependency on external binary

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested review from a team as code owners July 26, 2024 09:05
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for testkube-docs-preview failed.

Name Link
🔨 Latest commit d46e6e6
🔍 Latest deploy log https://app.netlify.com/sites/testkube-docs-preview/deploys/66a366c5b5bb510008311893

@rangoo94 rangoo94 merged commit 506bb9b into develop Jul 26, 2024
7 of 11 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/replace-skopeo-with-crane branch July 26, 2024 13:24
rangoo94 added a commit that referenced this pull request Aug 14, 2024
rangoo94 added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants