feat: [TKC-2623] testkube kind Docker image #5867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
vsukhin
changed the title
|
wow! should this be in its own repo? could it be possible to pass env/org/agent ids to connect to a control plane? |
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
rangoo94
reviewed
Sep 26, 2024
build/kind/cloud/entrypoint.sh
Outdated
| fi | ||
|
|
||
| # Check if cloud url is provided | ||
| if [ -z "$CLOUD_URL" ]; then |
There was a problem hiding this comment.
Isn't that rather ROOT_DOMAIN?
There was a problem hiding this comment.
I just followed exsitng agent helm installation command --set testkube-api.cloud.url=agent.testkube.io:443, will ROOT_DOMAI will be clear for user?
rangoo94
reviewed
Sep 26, 2024
build/kind/cloud/entrypoint.sh
Outdated
| log "You can now use Testkube in your Kind Kubernetes cluster." | ||
|
|
||
| # Step 10: Bring docker service back to foreground | ||
| fg %1 |
There was a problem hiding this comment.
Shouldn't it maybe instead stream Agent + Control Plane logs?
There was a problem hiding this comment.
it's just for Agent for now. actually, last part is for demoing purpose, it's not needed for agent work. so user can see that it works. he can always run the shell and check the agent logs
rangoo94
reviewed
Sep 26, 2024
Co-authored-by: Dawid Rusnak <dawid@drcode.pl>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
vsukhin
changed the title
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Docker image for running Testkube Agent in Docker (OSS and Cloud)
Checklist (choose whats happened)
Breaking changes
Changes
Fixes