Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid retrieving container logs again, when expected information is complete #5868

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: avoid retrieving container logs again, when expected information is complete #5868

merged 1 commit into from
Sep 25, 2024

Conversation

rangoo94
Copy link
Member

@rangoo94 rangoo94 commented Sep 25, 2024 •
edited
Loading

Pull request description

  • Earlier, for every container we were retrieving the logs twice - just to ensure that we haven't fall into log rotation
    • This fix will avoid additional retrieve, in most common case - when we have successfully received final step information

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner September 25, 2024 13:45
@rangoo94 rangoo94 merged commit 4e2a0ee into main Sep 25, 2024
22 of 23 checks passed
@rangoo94 rangoo94 deleted the dawid/feat/avoid-reloading-container-logs-when-all-expected-infromation-has-been-delivered branch September 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin