Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle optional steps #5922

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: handle optional steps #5922

merged 2 commits into from
Oct 14, 2024

Conversation

rangoo94
Copy link
Member

Pull request description

Failure of optional steps is now marking the whole execution to fail.

  • It should not fail execution, if optional step fails
kind: TestWorkflow
apiVersion: testworkflows.testkube.io/v1
metadata:
  name: optional-failure
spec:
  steps:
  - optional: true
    shell: exit 1

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

@rangoo94 rangoo94 requested a review from a team as a code owner October 11, 2024 11:08
@rangoo94 rangoo94 force-pushed the dawid/fix/optional-steps branch 2 times, most recently from cca81a0 to 203ac79 Compare October 11, 2024 11:14
@rangoo94 rangoo94 force-pushed the dawid/fix/optional-steps branch from 203ac79 to dbcf64b Compare October 11, 2024 11:14
@rangoo94 rangoo94 merged commit 9b92457 into main Oct 14, 2024
7 checks passed
@rangoo94 rangoo94 deleted the dawid/fix/optional-steps branch October 14, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rangoo94 @vsukhin