Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [TKC-2765] run test workflows by selector #6016

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

feat: [TKC-2765] run test workflows by selector #6016

wants to merge 20 commits into from

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Nov 8, 2024 •
edited
Loading

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@vsukhin
feat: run test workflows by selector
7c2a00d 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: log typo
72315f9 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: selector for execute op
dfde32e 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: dep update
7b80920 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: execute method with selector
5b0f92d 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: check if name is not empty
1414b76 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: exit on error code
779100c 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: update help
9e029d8 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: switch to error merhods
bfb82dc 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: error text
f33c5c9 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: join errors
2a5a728 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use existing naming in cli
a1f7045 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: move common part
970d017 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin marked this pull request as ready for review November 12, 2024 22:11
@vsukhin vsukhin requested a review from a team as a code owner November 12, 2024 22:11
@vsukhin
Merge branch 'main' into vsukhin/feature/run-workflow-selector
28e5972
@vsukhin
fix: help
238c55b 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: add execute test workflows api method spec
235680a 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
rangoo94
rangoo94 reviewed Nov 14, 2024
View reviewed changes
cmd/kubectl-testkube/commands/testworkflows/run.go Outdated Show resolved Hide resolved
pkg/api/v1/client/interface.go Outdated Show resolved Hide resolved
api/v1/testkube.yaml Show resolved Hide resolved
internal/app/api/v1/testworkflows.go Outdated Show resolved Hide resolved
pkg/api/v1/client/testworkflow.go Outdated Show resolved Hide resolved
vsukhin and others added 4 commits November 14, 2024 16:24
@vsukhin @rangoo94
Update pkg/api/v1/client/interface.go
67ecf66 
Co-authored-by: Dawid Rusnak <dawid@drcode.pl>
@vsukhin
fix: remove concurrency level
fb46a3a 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use Label Selector
e69a2f9 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: check for empty name and selector
e907ab8 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rangoo94 rangoo94 rangoo94 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsukhin @rangoo94