Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [TKC-2882] stream service and parallel step logs #6052

Merged
merged 47 commits into from
Dec 9, 2024
Merged

feat: [TKC-2882] stream service and parallel step logs #6052

merged 47 commits into from
Dec 9, 2024

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Nov 25, 2024 •
edited
Loading

Pull request description

  • add api endpoints to stream service and parallel step logs using websockets and sse
  • add cli command parameters to watch service and parallel step logs
  • add new client methods
  • add grpc method to stream service and parallel step logs
  • add proto methods

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

vsukhin added 10 commits November 25, 2024 18:12
@vsukhin
feat: api methods for service logs
bd39964 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: client for get service logs
2c77962 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: change log
c71f5c8 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: disable hints
3e70a83 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: routing
aa9acb3 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: show service logs
68fe09f 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: check service name
c55187f 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: check service name
93b7ac6 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: log comment
cf2dd76 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: check for testworkflow service
fff63c0 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin marked this pull request as ready for review November 27, 2024 11:23
@vsukhin vsukhin requested a review from a team as a code owner November 27, 2024 11:23
@vsukhin
fix: friendly error
c7bed19 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add spinner
f34e5d1 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: proto for service notifications
07ce308 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: add cloud grpc method for server notifications
9c03fe4 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: change timeeout
9d85b35 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: waiting for service pod
57db7a0 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: typo
cccfcb7 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: waiting for service pod
c4658c5 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add service name check
3768550 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: adjust help
c2fd448 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add method to parallel step
b46bb41 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use retry library
59bdce3 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: rename const
4224930 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: 0 attempts
bcda47f 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use option
97b5bd3 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: remove ctx
3e2c45f 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: add cli support for parallel steps
2819e43 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: rename url
81b0295 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
feat: api methods for parallel steps
c71fb91 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: tune parallel step detection
6003cde 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: typo
5136c31 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: cli
6b89ab0 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin changed the title feat: [TKC-2882] stream service logs feat: [TKC-2882] stream service and parallel logs Dec 2, 2024
vsukhin added 11 commits December 2, 2024 20:05
@vsukhin
feat: add proto for parallel step logs
bcffbd5 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: lint
bfdc72f 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
add: grpc method for parallel steps
ce5215f 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: comments
fdffbc9 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: comments
38379b4 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
Merge branch 'main' into vsukhin/feature/stream-service-logs
9d4c5fa
@vsukhin
fix: typo
8a7f8cb 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: change proto
097fb7d 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: rename fields
75d7f88 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
Merge branch 'main' into vsukhin/feature/stream-service-logs
f37671e
@vsukhin
fix: use const
cd1be6e 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin changed the title feat: [TKC-2882] stream service and parallel logs feat: [TKC-2882] stream service and parallel step logs Dec 4, 2024
@vsukhin
fix: check for empty result
38f959c 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
exu
exu reviewed Dec 9, 2024
View reviewed changes
cmd/api-server/main.go Outdated Show resolved Hide resolved
@vsukhin
fix: move methods to agent package
288be72 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: send org and env ids
e56e548 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add org and env ids
e899798 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin merged commit 8f3f8de into main Dec 9, 2024
7 checks passed
@vsukhin vsukhin deleted the vsukhin/feature/stream-service-logs branch December 9, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WitoDelnat WitoDelnat WitoDelnat left review comments

@rangoo94 rangoo94 rangoo94 left review comments

@exu exu exu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsukhin @exu @rangoo94 @WitoDelnat