Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [TKC-2895] pvc config #6074

Merged
merged 37 commits into from
Dec 19, 2024
Merged

feat: [TKC-2895] pvc config #6074

merged 37 commits into from
Dec 19, 2024

Conversation

vsukhin
Copy link
Collaborator

@vsukhin vsukhin commented Dec 11, 2024 •
edited
Loading

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@vsukhin
feat: pvc config
7530e05 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin changed the title feat: pvc config feat: [TKC-2895] pvc config Dec 11, 2024
@vsukhin
fix: rename var
6d67658 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: dep update
76ea394 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: map pvc to api
6b99bc4 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: map to kube
a7c36c0 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add pvc to control plane
8e8d073 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
cleanup pvcs
3bbba25 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
vsukhin added 20 commits December 12, 2024 14:49
@vsukhin
fix: merge pvcs map
d9fcff8 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add pvcs to service spec
bd2cf57 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: remove duplication
0d02d16 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: dep update
b85e274 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: setvice pvcs
fd2dd60 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fi: dep update
551f1b2 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: append pvcs
6faffdb 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: copy service pvcs
da9e7f1 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: pvc name for execution
5417211 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: register pvc names
597a69a 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: convert pvc
bd3aad2 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: move fields to boxed strings
95c8992 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: dep update
54b352d 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
Merge branch 'main' into vsukhin/feature/test-workflow-pvcs
c83e10b
@vsukhin
fix: pass pvc names
3520a1a 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: renname cobfig field
6effa79 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: remove var
f89592e 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: add new pvc config fields
c47ff99 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: pvc mapping
f2dd57b 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: json tag
a6f70f4 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use proper pvc name
bc49ed2 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: merge maps
ea3e45c 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: api spec format
691a5e9 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: typo
19fadbf 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: format methods
f242e45 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use map instead of slice
978e7aa 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: rename method
1ae2d0a 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin marked this pull request as ready for review December 18, 2024 15:06
@vsukhin vsukhin requested a review from a team as a code owner December 18, 2024 15:06
rangoo94
rangoo94 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@rangoo94 rangoo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with unique names, besides LGTM 👍

pkg/testworkflows/testworkflowprocessor/intermediate.go Outdated Show resolved Hide resolved
@vsukhin
fix: unique ref
9de4313 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: use root id
2ecd423 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin
fix: dep update
6c46caa 
Signed-off-by: Vladislav Sukhin <vladislav@kubeshop.io>
@vsukhin vsukhin merged commit a0e4eef into main Dec 19, 2024
7 checks passed
@vsukhin vsukhin deleted the vsukhin/feature/test-workflow-pvcs branch December 19, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rangoo94 rangoo94 rangoo94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsukhin @rangoo94