feat: [TKC-3016] add defaultConfigs for TestWorkflow executions #6090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rangoo94
reviewed
Dec 18, 2024
vsukhin
reviewed
Dec 18, 2024
vsukhin
reviewed
Dec 18, 2024
vsukhin
approved these changes
Dec 18, 2024
rangoo94
approved these changes
Dec 18, 2024
| return *result.UnscapeDots(), err | ||
| } | ||
|
|
||
| func (r *MongoRepository) populateConfigParams(resolvedWorkflow *testkube.TestWorkflow, configParams map[string]testkube.TestWorkflowExecutionConfigValue) { |
There was a problem hiding this comment.
Not important: I don't think it should be part of this struct, as it's completely independent
| func (r *MongoRepository) GetExecutionsSummary(ctx context.Context, filter Filter) (result []testkube.TestWorkflowExecutionSummary, err error) { | ||
| result = make([]testkube.TestWorkflowExecutionSummary, 0) | ||
| executions := make([]TestWorkflowExecutionSummaryWithResolvedWorkflow, 0) |
There was a problem hiding this comment.
Better to avoid fetching unnecessary data there. You can either - change the query to fetch only important part, or even better - adjust the aggregate to provide these data.
There was a problem hiding this comment.
Also, we have different pipelines for Enterprise, so it's very important to test it through.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Checklist (choose whats happened)
Breaking changes
Changes
Fixes