Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(/scripts): add cors settings #632

Merged
merged 1 commit into from
Dec 9, 2021
Merged

feat(/scripts): add cors settings #632

merged 1 commit into from
Dec 9, 2021

Conversation

nicufk
Copy link
Contributor

@nicufk nicufk commented Dec 9, 2021

Pull request description

Dashboard needs to access scripts endpoint from the api-server.

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

@nicufk nicufk added the enhancement New feature or request label Dec 9, 2021
@nicufk nicufk added this to the 0.7.5 milestone Dec 9, 2021
@nicufk nicufk self-assigned this Dec 9, 2021
@nicufk nicufk merged commit 301ec47 into main Dec 9, 2021
@nicufk nicufk deleted the nicolae/feat/add-cors-for-scripts branch December 9, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Toxer10 Toxer10 Toxer10 approved these changes

@jasmingacic jasmingacic jasmingacic approved these changes

@exu exu Awaiting requested review from exu

@olensmar olensmar Awaiting requested review from olensmar

@fog1985 fog1985 Awaiting requested review from fog1985

Assignees

@nicufk nicufk

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.5
Development

Successfully merging this pull request may close these issues.
3 participants
@nicufk @jasmingacic @Toxer10