Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): use correct web dashboard URL #4053

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix(cli): use correct web dashboard URL #4053

merged 2 commits into from
Oct 18, 2024

Conversation

schoren
Copy link
Contributor

@schoren schoren commented Oct 18, 2024

This PR fixes the tracetest dashboard command to use the correct URL. It was directing users to api.tracetest.io, resulting in a blank 404 page.
Now the command will try to use the configured env URL, if no env is set fallback to the uiEndpoint ("https://app.tracetest.io"), and ultimately return the api url, which was the original behavior, and requried for OSS

Changes

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Loom video

Add your loom video here if your work can be visualized

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:06pm

@schoren schoren merged commit 6b281e6 into main Oct 18, 2024
40 checks passed
@schoren schoren deleted the fix-dashboard-url branch October 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants