Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature slicegw lb #314

Closed
wants to merge 2 commits into from
Closed

Feature slicegw lb #314

wants to merge 2 commits into from

Conversation

narmidm
Copy link
Member

@narmidm narmidm commented Oct 5, 2023

Description

Fixes #

How Has This Been Tested?

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?

@bharath-avesha
feat(): Support LB svc type for slice GW
c9f8031 
Signed-off-by: Bharath Horatti <bharath@aveshasystems.com>
@bharath-avesha
feat(): Updated go.mod to pick up api changes
8c57742 
Signed-off-by: Bharath Horatti <bharath@aveshasystems.com>
@narmidm narmidm closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath-avesha bharath-avesha Awaiting requested review from bharath-avesha bharath-avesha is a code owner

@YachikaRalhan YachikaRalhan Awaiting requested review from YachikaRalhan

@Rahul-D78 Rahul-D78 Awaiting requested review from Rahul-D78 Rahul-D78 is a code owner

@rahulsawra98 rahulsawra98 Awaiting requested review from rahulsawra98

@gourishkb gourishkb Awaiting requested review from gourishkb gourishkb is a code owner

@mridulgain mridulgain Awaiting requested review from mridulgain mridulgain is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narmidm @bharath-avesha