Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SCM webhook to trigger Pipelines #597

Merged
merged 8 commits into from
Jun 7, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented May 25, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Supported SCM providers:

  • GitHub (SaaS)
  • Gitlab (SaaS)
  • Bitbucket (SaaS)

See the permission part kubesphere/ks-installer#1998

Image of this PR:

kubespheredev/devops-apiserver:dev-v3.3.0-alpha.1-d92409f

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

  • Already committed the CRD files to the Helm Chart if you created some new CRDs
  • Already added the permission for the new API
  • Already added the RBAC markers for the new controllers

Does this PR introduce a user-facing change??

Add SCM webhook to trigger Pipelines

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from linuxsuren after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note and removed do-not-merge/release-note-label-needed labels May 25, 2022
@ks-ci-bot ks-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #597 (b859c43) into master (ae9db96) will increase coverage by 0.07%.
The diff coverage is 78.18%.

@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   77.29%   77.37%   +0.07%     
==========================================
  Files         146      149       +3     
  Lines       23308    23416     +108     
==========================================
+ Hits        18015    18117     +102     
- Misses       5078     5079       +1     
- Partials      215      220       +5     
Flag Coverage Δ
unittests 77.37% <78.18%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/kapis/devops/v1alpha3/pipelinerun/util.go 78.43% <0.00%> (+44.43%) ⬆️
pkg/kapis/devops/v1alpha3/webhook/scm.go 70.12% <70.12%> (ø)
pkg/api/devops/v1alpha3/last_changes.go 100.00% <100.00%> (ø)
pkg/api/devops/v1alpha3/pipeline_types.go 100.00% <100.00%> (ø)
pkg/jwt/token/fake_issuer.go 100.00% <100.00%> (ø)
pkg/kapis/devops/v1alpha3/register.go 100.00% <100.00%> (ø)
pkg/kapis/devops/v1alpha3/webhook/register.go 100.00% <100.00%> (ø)
pkg/models/pipeline/pipeline.go 100.00% <100.00%> (ø)
...ns/devopscredential/devopscredential_controller.go 33.33% <0.00%> (-3.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae9db96...b859c43. Read the comment docs.

@LinuxSuRen LinuxSuRen merged commit 058ff4d into kubesphere:master Jun 7, 2022
@LinuxSuRen LinuxSuRen deleted the webhook branch June 7, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants