Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert prometheus service monitor selector #1953

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Apr 24, 2022

It just synchronizes update in https://github.com/kubesphere/ks-prometheus/pull/5 to here.

/cc @benjaminhuo

Signed-off-by: junot <junotxiang@kubesphere.io>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 24, 2022
@benjaminhuo
Copy link
Member

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d97ba2f26ebc50957b015fd727d3bbe748f52771

@benjaminhuo
Copy link
Member

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benjaminhuo, junotx
To complete the pull request process, please assign pixiake after the PR has been reviewed.
You can assign the PR to them by writing /assign @pixiake in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminhuo benjaminhuo merged commit 41e95a9 into kubesphere:master Apr 24, 2022
@pixiake
Copy link
Collaborator

pixiake commented Apr 26, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1958

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@junotx junotx deleted the revert branch February 28, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants