Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix "namespace_override" for library #1966

Merged
merged 1 commit into from
Apr 29, 2022
Merged

fix "namespace_override" for library #1966

merged 1 commit into from
Apr 29, 2022

Conversation

pixiake
Copy link
Collaborator

@pixiake pixiake commented Apr 29, 2022

What this PR does / why we need it:

Fix the problem that namespace_override doesn't work for images using library.

Signed-off-by: pixiake guofeng@yunify.com

@pixiake
fix namespace_override for library
7c8ee69 
Signed-off-by: pixiake <guofeng@yunify.com>
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2022
@pixiake pixiake linked an issue Apr 29, 2022 that may be closed by this pull request
kk 在使用私有registry仓库harbor，存在redis私有仓库namespace为library，不是配置的namespaceOverride: "kubesphereio" #1964
Closed
@pixiake
Copy link
Collaborator Author

pixiake commented Apr 29, 2022

/cc @kubesphere/sig-installation

@ks-ci-bot ks-ci-bot requested a review from a team April 29, 2022 05:32
@pixiake
Copy link
Collaborator Author

pixiake commented Apr 29, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@24sama
Copy link
Contributor

24sama commented Apr 29, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: d800dd1956ca13951de4d7641d7faee8eb693c0a

@ks-ci-bot ks-ci-bot merged commit 1c849a3 into kubesphere:master Apr 29, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request Apr 29, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1967

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@24sama 24sama

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@pixiake @ks-ci-bot @24sama