Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the project-operator JSON format #1968

Merged
merged 1 commit into from
May 4, 2022
Merged

Fix the project-operator JSON format #1968

merged 1 commit into from
May 4, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented Apr 29, 2022 •
edited
Loading

/area devops

fix kubesphere/ks-devops#575

I have tested it manually. See the following screenshot:
image

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2022
@LinuxSuRen
Copy link
Member Author

/hold

@LinuxSuRen
Copy link
Member Author

/unhold
/cc @kubesphere/sig-installation

@ks-ci-bot ks-ci-bot requested a review from a team April 29, 2022 08:44
@LinuxSuRen
Copy link
Member Author

/area devops
/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/area devops
/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented May 4, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: aa88ae2b94dca36227ffd90a8cc5ec034d9d4cd8

@pixiake
Copy link
Collaborator

pixiake commented May 4, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@ks-ci-bot ks-ci-bot merged commit 66a6b63 into kubesphere:master May 4, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request May 4, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: new pull request created: #1970

In response to this:

/area devops
/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the project-operator branch May 4, 2022 09:35
@wansir wansir mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Permission error for role ’operator‘ of devops
3 participants
@LinuxSuRen @ks-ci-bot @pixiake