Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.3] fix Dockerfile wildcard character error #1981

Merged
merged 1 commit into from
May 9, 2022
Merged

[release-3.3] fix Dockerfile wildcard character error #1981

merged 1 commit into from
May 9, 2022

Conversation

besscroft
Copy link
Contributor

test environment:
OS: Debian GNU/Linux 10 (buster) aarch64
Host: KVM Virtual Machine virt-4.2
Kernel: 4.19.0-20-arm64

if [[ $(arch) == "aarch64*" ]]; then ARCH=arm64; fi -> failed
if [[ $(arch) == "aarch64"* ]]; then ARCH=arm64; fi -> success
if [[ $(arch) == aarch64* ]]; then ARCH=arm64; fi -> success

I tried testing inside a Docker container and on the host machine, "aarch64*" -> failed.

This results in the inability to download the correct package in the arm64 environment.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2022
@besscroft
Copy link
Contributor Author

besscroft commented May 7, 2022

2 suggestions:

  1. remove wildcards.
  2. Translate to alternative arch names used in multiarch images.

Example:

if [ $(arch) == "amd64"   ]; then ARCH=amd64; fi
if [ $(arch) == "i386"    ]; then ARCH=i386; fi
if [ $(arch) == "aarch64" ]; then ARCH=arm64; fi

Can consider which way is more suitable, I can make corresponding adjustments and re-issue the PR.

@pixiake
Copy link
Collaborator

pixiake commented May 9, 2022

@besscroft Thanks for this contribution. I think this pr can be adopted at present.

@pixiake
Copy link
Collaborator

pixiake commented May 9, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 38e7f5f2dfc4ad8c48d278135cd356d7547d7e57

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: besscroft, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@ks-ci-bot ks-ci-bot merged commit 4243e2f into kubesphere:release-3.3 May 9, 2022
@pixiake
Copy link
Collaborator

pixiake commented May 9, 2022

/cherrypick master

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #1982

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants