-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.3] fix Dockerfile wildcard character error #1981
Conversation
2 suggestions:
Example: if [ $(arch) == "amd64" ]; then ARCH=amd64; fi
if [ $(arch) == "i386" ]; then ARCH=i386; fi
if [ $(arch) == "aarch64" ]; then ARCH=arm64; fi Can consider which way is more suitable, I can make corresponding adjustments and re-issue the PR. |
@besscroft Thanks for this contribution. I think this pr can be adopted at present. |
/lgtm |
LGTM label has been added. Git tree hash: 38e7f5f2dfc4ad8c48d278135cd356d7547d7e57
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: besscroft, pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick master |
@pixiake: new pull request created: #1982 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
test environment:
OS: Debian GNU/Linux 10 (buster) aarch64
Host: KVM Virtual Machine virt-4.2
Kernel: 4.19.0-20-arm64
if [[ $(arch) == "aarch64*" ]]; then ARCH=arm64; fi -> failed
if [[ $(arch) == "aarch64"* ]]; then ARCH=arm64; fi -> success
if [[ $(arch) == aarch64* ]]; then ARCH=arm64; fi -> success
I tried testing inside a Docker container and on the host machine, "aarch64*" -> failed.
This results in the inability to download the correct package in the arm64 environment.