add remove old kubeedge task #1983
Conversation
ks-ci-bot
added
approved
|
@wenchajun Please double check that Maybe use kubesphere v3.2.1 to test |
| @@ -1,3 +1,8 @@ | |||
| - name: KubeEdge | Remove old kubeedge | |||
| shell: > | |||
| {{ bin_dir }}/helm del kubeedge -n kubeedge | |||
There was a problem hiding this comment.
This I tested in my local environment, I used the command helm del kubeedge -n kubeedge and it showed that iptable was not uninstalled, when I used another command helm uninstall kubeedge -n kubeedge, it showed success, is it possible to use the command uninstall?
There was a problem hiding this comment.
Both the EdgeWatcher deployment and the EdgeWatcherAgent daemonset can be deleted after helm uninstall kubeedge -n kubeedge ?
There was a problem hiding this comment.
I have updated the tasks of removing old kubeedge.
Signed-off-by: pixiake <guofeng@yunify.com>
ks-ci-bot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pixiake, wenchajun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 29941563856dbec5218a99dad013453e1d7391f7
|
| shell: | | ||
| {{ bin_dir }}/helm uninstall kubeedge -n kubeedge | ||
| {{ bin_dir }}/kubectl patch iptables -n kubeedge iptables -p '{"metadata":{"finalizers":null}}' --type merge | ||
| {{ bin_dir }}/kubectl delete ds -n kubeedge iptables |
There was a problem hiding this comment.
Maybe we need to remove CR of iptablesrules as well?
There was a problem hiding this comment.
I not found CR of iptablesrules in cluster. When will the CR of iptablesrules be created?
There was a problem hiding this comment.
I just tested it, and CR of iptablesrules will be automatically deleted, which will not affect the uninstallation of kubeedge.
|
/cherrypick release-3.3 |
|
@pixiake: new pull request created: #1988 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The old version kubeedge, if it exists, should be deleted, otherwise there will be a conflict between the old and new versions.
Signed-off-by: pixiake guofeng@yunify.com