Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the potential webhook-related issues #1984

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix the potential webhook-related issues #1984

merged 1 commit into from
May 11, 2022

Conversation

LinuxSuRen
Copy link
Member

@LinuxSuRen LinuxSuRen commented May 11, 2022 •
edited
Loading

I have tested it manually with the following image:

kubespheredev/ks-installer:master-dev-1a88252c

/area devops
fix kubesphere/ks-devops#586

@LinuxSuRen
Fix the potential webhook-related issues
3a5d28d 
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@ks-ci-bot ks-ci-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 11, 2022
@LinuxSuRen
Copy link
Member Author

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen
Copy link
Member Author

/area devops

@pixiake
Copy link
Collaborator

pixiake commented May 11, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: a6588e337bb8350c2a67aec221d56998b8dd1f39

@ks-ci-bot ks-ci-bot merged commit d4d7530 into kubesphere:master May 11, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request May 11, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: new pull request created: #1985

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the fix-webhook-issues branch May 11, 2022 10:34
@LinuxSuRen LinuxSuRen mentioned this pull request May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ks3.2.1 to ks3.3.0-alpha, devops upgrade error
3 participants
@LinuxSuRen @ks-ci-bot @pixiake