Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support to use an alternative image build tool #1989

Merged
merged 1 commit into from
May 12, 2022
Merged

Support to use an alternative image build tool #1989

merged 1 commit into from
May 12, 2022

Conversation

LinuxSuRen
Copy link
Member

See my test output:

rick@DESKTOP-KSDCPBK:~/ws/github/kubesphere/ks-installer$ podman images | head
REPOSITORY                                TAG                   IMAGE ID      CREATED       SIZE
docker.io/library/alpine                  latest                0ac33e5f5afa  5 weeks ago   5.86 MB
rick@DESKTOP-KSDCPBK:~/ws/github/kubesphere/ks-installer$ echo $CONTAINER_CLI
podman
rick@DESKTOP-KSDCPBK:~/ws/github/kubesphere/ks-installer$ make build
podman build . --file Dockerfile --tag kubespheredev/ks-installer:master-dev-833dfa3e
STEP 1/8: FROM kubespheredev/shell-operator:v1.0.0-beta.5-alpine
STEP 2/8: ENV  ANSIBLE_ROLES_PATH /kubesphere/installer/roles
--> Using cache 0fd53e651e354bb5abc8b3acb444728340e2f41d6cb9dfd19cb3858345252439
--> 0fd53e651e3
STEP 3/8: WORKDIR /kubesphere
--> Using cache c3c9668b8a4af18ec352341d5c9beaad75baff1392ab4b3168b75f42da708bb7

@LinuxSuRen
Support to use an alternative image build tool
1de8eb5 
Signed-off-by: rick <1450685+LinuxSuRen@users.noreply.github.com>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2022
@pixiake
Copy link
Collaborator

pixiake commented May 12, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9c614ba2763ed11975b9b6c27e67185cb378b11f

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2022
@ks-ci-bot ks-ci-bot merged commit 0fa7c1c into kubesphere:master May 12, 2022
@LinuxSuRen LinuxSuRen deleted the podman-support branch May 12, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pixiake pixiake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinuxSuRen @pixiake @ks-ci-bot