Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gitops.kubesphere.io group to the global management role #1997

Merged
merged 2 commits into from
May 26, 2022
Merged

Add gitops.kubesphere.io group to the global management role #1997

merged 2 commits into from
May 26, 2022

Conversation

LinuxSuRen
Copy link
Member

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2022
@LinuxSuRen
Copy link
Member Author

/cherrypick release-3.3
/cc @pixiake

@ks-ci-bot ks-ci-bot requested a review from pixiake May 24, 2022 06:05
@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3
/cc @pixiake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen
Copy link
Member Author

/area devops

@wansir
Copy link
Member

wansir commented May 24, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 9872ebd2aa1097c770a8067795f3b27f1c5839d9

@LinuxSuRen
Copy link
Member Author

Please feel free to help us to test it with the following image:

surenpi/ks-installer:add-gitops-to-global-dev-e9bb1105

@LinuxSuRen LinuxSuRen mentioned this pull request May 25, 2022
Closed
@wansir
Copy link
Member

wansir commented May 25, 2022

/approve

2 similar comments
@zheng1
Copy link
Member

zheng1 commented May 25, 2022

/approve

@pixiake
Copy link
Collaborator

pixiake commented May 26, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LinuxSuRen, pixiake, wansir, zheng1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2022
@ks-ci-bot ks-ci-bot merged commit cfddced into kubesphere:master May 26, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request May 26, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@LinuxSuRen: new pull request created: #2001

In response to this:

/cherrypick release-3.3
/cc @pixiake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LinuxSuRen LinuxSuRen deleted the add-gitops-to-global branch May 26, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixiake pixiake Awaiting requested review from pixiake

Assignees

@wansir wansir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devops lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enterprise Space Administrator Sync Continuous Deployment Fails
5 participants
@LinuxSuRen @ks-ci-bot @wansir @zheng1 @pixiake