Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: err format at gatekeeper webhook template #2009

Merged
merged 1 commit into from
Jun 7, 2022
Merged

fix: err format at gatekeeper webhook template #2009

merged 1 commit into from
Jun 7, 2022

Conversation

sagilio
Copy link
Contributor

@sagilio sagilio commented Jun 4, 2022 •
edited
Loading

Fixes: #2008

@sagilio
fix: err format at gatekeeper webhook template
25ad7f8 
Signed-off-by: sagilio <sagilio@outlook.com>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2022
@sagilio
Copy link
Contributor Author

sagilio commented Jun 4, 2022

/cc @wansir

@ks-ci-bot ks-ci-bot requested a review from wansir June 4, 2022 20:28
@pixiake
Copy link
Collaborator

pixiake commented Jun 7, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wansir
Copy link
Member

wansir commented Jun 7, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: e1413c00f2e487f7e4cd973ebcdfdac1b8f61ab6

@pixiake
Copy link
Collaborator

pixiake commented Jun 7, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, sagilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@ks-ci-bot ks-ci-bot merged commit 1c0e093 into kubesphere:master Jun 7, 2022
@ks-ci-bot ks-ci-bot mentioned this pull request Jun 7, 2022
Merged
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2012

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wansir wansir Awaiting requested review from wansir

Assignees

@wansir wansir

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gatekeeper webhook template format error
4 participants
@sagilio @pixiake @ks-ci-bot @wansir