-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize ks-istio monitoring and reduce useless metrics #2013
Conversation
Signed-off-by: frezes <zhangjunhao@kubesphere.io>
/cc @junotx @hongzhouzi |
@frezes: GitHub didn't allow me to request PR reviews from the following users: hongzhouzi. Note that only kubesphere members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It looks good to me. @hongzhouzi please confirm it contains all metrics used by istio or servicemesh module |
@junotx: GitHub didn't allow me to request PR reviews from the following users: hongzhouzi. Note that only kubesphere members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-3.3 |
@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 3a6a0ec1c4c269e0e16e3e5f978eec70bdd587cb
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frezes, pixiake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pixiake: new pull request created: #2018 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ks-istio envoy-stats-monitor contains a lot of useless metrics, in order to reduce prometheus load, add metricRelabelings for filtering