Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize ks-istio monitoring and reduce useless metrics #2013

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

frezes
Copy link
Member

@frezes frezes commented Jun 8, 2022

ks-istio envoy-stats-monitor contains a lot of useless metrics, in order to reduce prometheus load, add metricRelabelings for filtering

Signed-off-by: frezes <zhangjunhao@kubesphere.io>
@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 8, 2022
@frezes
Copy link
Member Author

frezes commented Jun 9, 2022

/cc @junotx @hongzhouzi

@ks-ci-bot ks-ci-bot requested a review from junotx June 9, 2022 02:06
@ks-ci-bot
Copy link
Collaborator

@frezes: GitHub didn't allow me to request PR reviews from the following users: hongzhouzi.

Note that only kubesphere members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @junotx @hongzhouzi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@junotx
Copy link
Contributor

junotx commented Jun 9, 2022

It looks good to me. @hongzhouzi please confirm it contains all metrics used by istio or servicemesh module
/cc @hongzhouzi

@ks-ci-bot
Copy link
Collaborator

@junotx: GitHub didn't allow me to request PR reviews from the following users: hongzhouzi.

Note that only kubesphere members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

It looks good to me. @hongzhouzi please confirm it contains all metrics used by istio or servicemesh module, and whether the sevicemonitor does contain some useless metrics
/cc @hongzhouzi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Jun 9, 2022

/cherrypick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: once the present PR merges, I will cherry-pick it on top of release-3.3 in a new PR and assign it to you.

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pixiake
Copy link
Collaborator

pixiake commented Jun 9, 2022

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 3a6a0ec1c4c269e0e16e3e5f978eec70bdd587cb

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frezes, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2022
@ks-ci-bot ks-ci-bot merged commit 290587c into kubesphere:master Jun 9, 2022
@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2018

In response to this:

/cherrypick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants