Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily remove rules with last_over_time function #2111

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

junotx
Copy link
Contributor

@junotx junotx commented Sep 19, 2022

This synchronizes update in https://github.com/kubesphere/ks-prometheus/pull/16 to temporarily remove rules with last_over_time function

Signed-off-by: junot <junotxiang@kubesphere.io>
@junotx
Copy link
Contributor Author

junotx commented Sep 19, 2022

/cc @benjaminhuo

@ks-ci-bot ks-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2022
@benjaminhuo
Copy link
Member

/lgtm
/approve

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: 51a9999190d68f7759dd363f53522cfee6351446

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminhuo, junotx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@ks-ci-bot ks-ci-bot merged commit 07cb0bd into kubesphere:master Sep 19, 2022
@junotx junotx deleted the alerting-v2beta1 branch September 22, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants