Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable manage-groups in custom role #2112

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

zhou1203
Copy link
Member

@zhou1203 zhou1203 commented Sep 23, 2022

Fix kubesphere/kubesphere#5224
Signed-off-by: Wenhao Zhou wenhaozhou@yunify.com

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2022
@zhou1203
Copy link
Member Author

/cc @wansir @pixiake

Signed-off-by: Wenhao Zhou <wenhaozhou@yunify.com>
@wansir
Copy link
Member

wansir commented Sep 26, 2022

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: f4c7a7d1d7a0c200d96ef407964965f43780a4a3

@pixiake
Copy link
Collaborator

pixiake commented Sep 27, 2022

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, zhou1203

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2022
@ks-ci-bot ks-ci-bot merged commit 37f99c1 into kubesphere:master Sep 27, 2022
@pixiake
Copy link
Collaborator

pixiake commented Sep 27, 2022

/cherry-pick release-3.3

@ks-ci-bot
Copy link
Collaborator

@pixiake: new pull request created: #2116

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The permissions of access control in workspace role is wrong.
4 participants