Using async_validate_{field} with Form's prefix

[zyzniewski]

class MyForm(starlette_wtf.StarletteForm):
    public = wtforms.BooleanField()

    def validate_public(self, field):
        print("YEP")

    async def async_validate_public(self, field):
        print("NOPE")

form = await MyForm.from_formdata(
    request,
    prefix="registers",
)
await form.validate()

raises the following exception:

  File "/home/zyzniewski/Projects/ChessManager/ChessManagerWeb/.venv/lib/python3.11/site-packages/starlette_wtf/form.py", line 156, in validate
    tasks = [self._validate_async(*async_validators[name]) for name in \
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/zyzniewski/Projects/ChessManager/ChessManagerWeb/.venv/lib/python3.11/site-packages/starlette_wtf/form.py", line 156, in <listcomp>
    tasks = [self._validate_async(*async_validators[name]) for name in \
                                   ~~~~~~~~~~~~~~~~^^^^^^
KeyError: 'registers-public'

caused by using field.name that contains Form's prefix: https://github.com/muicss/starlette-wtf/blob/f96ab6f33a7ffcb576663f996dbb401ab44f3d78/starlette_wtf/form.py#L143

[amorey]

Sorry, I missed this earlier! This is fixed in the latest version (0.4.4). Thanks the bug report!

[zyzniewski]

Hi, just got an exception:

KeyError: 'registers-registers-public'

at .<listcomp> ( /layers/google.python.pip/pip/lib/python3.11/site-packages/starlette_wtf/form.py:155 )
at .validate ( /layers/google.python.pip/pip/lib/python3.11/site-packages/starlette_wtf/form.py:155 )`

[amorey]

How is prefix being invoked? Can you share the code triggering the error?

[zyzniewski]

form = await Step2regs.from_formdata(
    request,
    meta={
        "tournament": tournament,
        "user": admin,
    },
    prefix="registers",
)

if await form.validate():
    ...

[amorey]

Thanks, can you share the form class definition and the template as well? There’s a unit test that has a similar setup to your code snippet so just based on this snippet I’m not sure where the second prefix is coming from.

[zyzniewski]

you're prepending the form's prefix in completed
https://github.com/amorey/starlette-wtf/blob/272d1767eb7662f971bb609f388f08019e4e353f/starlette_wtf/form.py#L143

field.name itself should contain the form prefix already:
https://github.com/wtforms/wtforms/blob/fef0952c0c130042d4727ebe944601d87662af0b/src/wtforms/fields/core.py#L113

while async_validators has just the raw field's name:
https://github.com/amorey/starlette-wtf/blob/272d1767eb7662f971bb609f388f08019e4e353f/starlette_wtf/form.py#L148

[amorey]

Got it, thanks. Try v0.4.5rc1 and let me know if that fixes the problem:

pip install starlette-wtf==0.4.5rc1

[zyzniewski]

That seems to work, thanks!

[amorey]

Awesome! Thanks again for the suggestion! I bumped the version number (0.4.5) and published it to pypi. Let me know if you run into any more problems.