Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor suspend step and add op.#Suspend #138

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 23, 2023

Description of your changes

This PR refactor suspend step, add new phase suspending and add op.#Suspend .

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 67.97% // Head: 68.24% // Increases project coverage by +0.27% 🎉

Coverage data is based on head (dd9e3a4) compared to base (edc7849).
Patch coverage: 56.41% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   67.97%   68.24%   +0.27%     
==========================================
  Files          48       47       -1     
  Lines        4334     4283      -51     
==========================================
- Hits         2946     2923      -23     
+ Misses       1022      996      -26     
+ Partials      366      364       -2     
Flag Coverage Δ
e2etests 25.43% <7.69%> (+0.36%) ⬆️
unit-test 65.13% <52.56%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/types.go 11.11% <ø> (ø)
pkg/cue/model/sets/operation.go 74.38% <ø> (ø)
pkg/tasks/builtin/step_group.go 62.13% <0.00%> (-6.69%) ⬇️
pkg/tasks/custom/task.go 70.14% <0.00%> (-1.28%) ⬇️
pkg/tasks/discover.go 93.33% <ø> (-0.42%) ⬇️
pkg/types/types.go 33.33% <ø> (ø)
pkg/executor/workflow.go 81.33% <69.69%> (-0.06%) ⬇️
pkg/providers/workspace/workspace.go 81.39% <74.07%> (-3.61%) ⬇️
pkg/generator/generator.go 68.54% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@FogDong FogDong merged commit ecaf98d into kubevela:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants