Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix terminate suspending steps #160

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Apr 18, 2023

Description of your changes

Fix: fix terminate suspending steps

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.80 ⚠️

Comparison is base (9c5da14) 67.55% compared to head (8fe456c) 66.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   67.55%   66.76%   -0.80%     
==========================================
  Files          50       50              
  Lines        4553     4553              
==========================================
- Hits         3076     3040      -36     
- Misses       1080     1108      +28     
- Partials      397      405       +8     
Flag Coverage Δ
e2etests 22.14% <0.00%> (-0.97%) ⬇️
unit-test 64.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/operation.go 78.10% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

Successfully created backport PR #161 for release-0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants