CNV-23376: Create new page for InstanceTypes VM creation flow #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivtur
force-pushed
the
instance-type-create-layout
branch
from
f36298e
to
e8c0641
Compare
pcbailey
reviewed
Dec 14, 2022
| <StackItem className="co-m-pane__heading"> | ||
| <Title headingLevel="h1">{t('Create new VirtualMachine')}</Title> | ||
| </StackItem> | ||
| <StackItem>{t('Select an option to create a VirtualMachine from.')}</StackItem> |
There was a problem hiding this comment.
We can ask Yifat about this if you want, but the correct English would be "Select an option from which to create a VirtualMachine."
There was a problem hiding this comment.
I've changed it, thanks :)
avivtur
force-pushed
the
instance-type-create-layout
branch
3 times, most recently
from
6bb63ec
to
e985e6e
Compare
avivtur
changed the title
avivtur
force-pushed
the
instance-type-create-layout
branch
2 times, most recently
from
2c286a6
to
e9ebfdc
Compare
avivtur
changed the title
avivtur
force-pushed
the
instance-type-create-layout
branch
3 times, most recently
from
ad920e1
to
19ae73f
Compare
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
avivtur
force-pushed
the
instance-type-create-layout
branch
from
19ae73f
to
a7a3cc2
Compare
avivtur
changed the title
|
This looks great! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aviv Turgeman aturgema@redhat.com
📝 Description
changes introduced by this PR:
HorizontalNavfrom the console and usedTabsfrom PF to have an icon and a label in the tab's title.CreateFromInstanceTypes, including dividing into sections and changing their styles with theonClickmethod.From bootable Volumeto VirtualMachine list view create dropdown.issue
UX design
sub task
🎥 Demo
instance-types-create-layout.mp4