Bug 2148850: Display help texts in MigrationPolicy details #1011
Conversation
|
@hstastna: This pull request references Bugzilla bug 2148850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hstastna: This pull request references Bugzilla bug 2148850, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
|
@hstastna: This pull request references Bugzilla bug 2148850, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hstastna: This pull request references Bugzilla bug 2148850, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
hstastna
force-pushed
the
BZ_Help_text_is_missing_in_MigrationPolicies_details
branch
from
b43ea86
to
8ac3c10
Compare
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
...tails/components/MigrationPolicyDetailsSection/components/MigrationPolicyDescriptionItem.tsx
Outdated
Show resolved
Hide resolved
hstastna
force-pushed
the
BZ_Help_text_is_missing_in_MigrationPolicies_details
branch
from
8ac3c10
to
f3dde42
Compare
Display help texts for the fields in MigrationPolicy details page. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2148850
hstastna
force-pushed
the
BZ_Help_text_is_missing_in_MigrationPolicies_details
branch
from
f3dde42
to
eb2860e
Compare
hstastna
requested review from
metalice
and removed request for
gouyang and
yaacov
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hstastna: All pull requests linked via external trackers have merged: Bugzilla bug 2148850 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
📝 Description
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=2148850
Display help texts for the fields in MigrationPolicy Details page/tab.
🎥 Screenshots
Before:
After clicking on the underlined title of the field, nothing happens:
After:
After clicking on the underlined title of the field, popover is displayed with the appropriate help text
(works for all of the underlined titles in the page now):