CNV-23983: Create a modal form to add a boot volume #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivtur
force-pushed
the
add-bootable-volume-modal
branch
3 times, most recently
from
4e3aae0
to
c8da642
Compare
pcbailey
reviewed
Jan 10, 2023
...teVMHorizontalNav/components/CreateFromInstanceTypes/hooks/useInstanceTypesAndPreferences.ts
Outdated
Show resolved
Hide resolved
src/views/catalog/CreateVMHorizontalNav/components/CreateFromInstanceTypes/utils/constants.ts
Outdated
Show resolved
Hide resolved
src/views/catalog/CreateVMHorizontalNav/components/CreateFromInstanceTypes/utils/utils.ts
Outdated
Show resolved
Hide resolved
metalice
reviewed
Jan 10, 2023
|
|
||
| import { SelectOption } from '@patternfly/react-core'; | ||
|
|
||
| export const getSelectOption = (optionLabel: string) => (name: string) => |
There was a problem hiding this comment.
hmm... get*** is misleading in this case, as this function eventually returns a component.
util files usually don't return elements/components.
|
very nice! GJ! left a small comment about 2 functions in the util file |
avivtur
force-pushed
the
add-bootable-volume-modal
branch
4 times, most recently
from
4a2adc2
to
e4e62dc
Compare
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
avivtur
force-pushed
the
add-bootable-volume-modal
branch
from
e4e62dc
to
85039d8
Compare
avivtur
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aviv Turgeman aturgema@redhat.com
📝 Description
A modal to create a DataVolume (with upload file or cloning an existing PVC) that adds the preferences and instanceType to a PVC as labels
🎥 Demo
Demo-adding-bootable-volume.mp4
To-Do