CNV-23381: Make necessary changes to VM details tabs #1026
Conversation
|
@avivtur: This pull request references CNV-23381 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -108,3 +109,6 @@ export const deleteVM = async (vm: V1VirtualMachine) => { | |||
| resource: vm, | |||
| }); | |||
| }; | |||
|
|
|||
| export const expandVirtualMachineSpec = async (vm: V1VirtualMachine) => | |||
There was a problem hiding this comment.
I think we should use expandVMSpec to stay consistent with the other commands here.
avivtur
force-pushed
the
expand_vm_spec
branch
2 times, most recently
from
5af34cb
to
91f36c2
Compare
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
avivtur
force-pushed
the
expand_vm_spec
branch
from
91f36c2
to
36b53d2
Compare
|
@avivtur: This pull request references CNV-23381 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
avivtur
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: avivtur, pcbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Aviv Turgeman aturgema@redhat.com
📝 Description
** Fixing a crash of VM disks tab, and cancelling the pending changes for VMs with instancetype or preference section included in the VM YAML
🎥 Demo