Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-21086: Remove Live migratable from VM Details #1031

Conversation

hstastna
Copy link

@hstastna hstastna commented Jan 28, 2023

📝 Description

This is the last another PR for the feature: https://issues.redhat.com/browse/CNV-21086

Remove forgotten unnecessary Live migratable field from VM Details page,
as this field was already replaced by the label, placed next to the Status of the VM,
see: #1008, #1013, #1018.

🎥 Screenshots

Before:
Live migratable field together with the label containing the same info:
live_before
After:
Only the label next to the Status:
live_after

Remove forgotten unnecessary 'Live migratable' field
from VM Details page, as this field was already replaced
by the label placed next to the Status of the VM.

Fixes https://issues.redhat.com/browse/CNV-21086
@openshift-ci-robot
Copy link
Collaborator

@hstastna: This pull request references CNV-21086 which is a valid jira issue.

In response to this:

📝 Description

This is the last PR for the feature: https://issues.redhat.com/browse/CNV-21086

Remove forgotten unnecessary Live migratable field from VM Details page,
as this field was already replaced by the label, placed next to the Status of the VM,
see: #1008, #1013, #1018.

🎥 Screenshots

Before:
Live migratable field together with the label containing the same info:
live_before
After:
Only the label next to the Status:
live_after

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from avivtur and yaacov January 28, 2023 00:39
@hstastna
Copy link
Author

@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jan 30, 2023
@metalice
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hstastna, metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jan 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3602a87 into kubevirt-ui:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants