Update Bootable volume's related strings #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@avivtur @metalice @pcbailey @upalatucci @vojtechszocs please review |
|
/retest |
|
/lgtm |
openshift-ci
bot
added
lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
hstastna
force-pushed
the
Create_VM_bootable_volume_change_strings
branch
from
f2839bf
to
ae137db
Compare
Change the related strings/texts used in the UI, according to the latest design changes: ListPageCreateDropdown items: - 'From catalog' -> 'From template' - 'From bootable volume' -> 'From volume' - 'With YAML' -> 'From YAML' Button: - 'Add bootable volume' -> 'Add volume' Modal title: - 'Add bootable volume' -> 'Add volume to boot from' Other strings: - 'Select bootable volume' -> 'Select volume to boot from'
hstastna
force-pushed
the
Create_VM_bootable_volume_change_strings
branch
from
ae137db
to
01d2849
Compare
|
@metalice @upalatucci @vojtechszocs please review |
|
@metalice I've updated the PR, and I think I've found and fixed the problem why the tests were failing. Can you please re-review/re-lgtm the PR? Thanks! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hstastna, metalice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Change the related strings/texts used in the UI according to the latest design changes:
ListPageCreateDropdownitems:Button:
Modal title:
Other strings:
This PR is related to features:
https://issues.redhat.com/browse/CNV-18014
https://issues.redhat.com/browse/CNV-15501
🎥 Demo
Before:
Create button to create a VM:
Add bootable volume button and 'Select bootable volume':
Add bootable volume modal:
After:
